Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NETOBSERV-1063: Add TCP drop & DNS tracking to flowlogs-pipeline #429

Merged
merged 4 commits into from
Jun 26, 2023
Merged

NETOBSERV-1063: Add TCP drop & DNS tracking to flowlogs-pipeline #429

merged 4 commits into from
Jun 26, 2023

Conversation

msherif1234
Copy link
Contributor

@msherif1234 msherif1234 commented Apr 29, 2023 •
edited

add TCPDrop and DNS tracking support
flatten ICMP fields

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 29, 2023 •
edited by openshift-ci bot

@msherif1234: This pull request references NETOBSERV-979 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 29, 2023 •
edited by openshift-ci bot

@msherif1234: This pull request references NETOBSERV-979 which is a valid jira issue.

In response to this:

add TCPDrop support
FIXME: once ebpf agent PR is merged we need to update vendor modules

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msherif1234 msherif1234 changed the title NETOBSERV-979: Add TCP drop to flowlogs-pipeline WIP NETOBSERV-979: Add TCP drop to flowlogs-pipeline Apr 29, 2023
@codecov
Copy link

codecov bot commented Apr 29, 2023 •
edited

Codecov Report

Merging #429 (1b22a95) into main (95395fc) will decrease coverage by 1.93%.
The diff coverage is 20.97%.

@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
- Coverage   64.74%   62.82%   -1.93%     
==========================================
  Files          94       96       +2     
  Lines        6651     6910     +259     
==========================================
+ Hits         4306     4341      +35     
- Misses       2102     2325     +223     
- Partials      243      244       +1
Flag Coverage Δ
unittests 62.82% <20.97%> (-1.93%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/pipeline/decode/decode_protobuf.go 26.58% <20.97%> (-50.35%) ⬇️

... and 19 files with indirect coverage changes

@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 29, 2023
@github-actions
Copy link

New image: quay.io/netobserv/flowlogs-pipeline:06ebf5e. It will expire after two weeks.

@msherif1234 msherif1234 requested a review from ronensc May 1, 2023 19:03
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 4, 2023
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 9, 2023
@github-actions
Copy link

github-actions bot commented May 9, 2023

New image: quay.io/netobserv/flowlogs-pipeline:8b9be56. It will expire after two weeks.

@msherif1234
NETOBSERV-979: Add TCP drop to flowlogs-pipeline
1c81d3e 
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 12, 2023
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 12, 2023
@github-actions
Copy link

New image: quay.io/netobserv/flowlogs-pipeline:613f227. It will expire after two weeks.

@msherif1234 msherif1234 changed the title WIP NETOBSERV-979: Add TCP drop to flowlogs-pipeline WIP NETOBSERV-1063: Add TCP drop to flowlogs-pipeline May 26, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 26, 2023 •
edited by openshift-ci bot

@msherif1234: This pull request references NETOBSERV-1063 which is a valid jira issue.

In response to this:

add TCPDrop support
FIXME: once ebpf agent PR is merged we need to update vendor modules

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jun 4, 2023
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jun 4, 2023
@github-actions
Copy link

github-actions bot commented Jun 4, 2023

New image: quay.io/netobserv/flowlogs-pipeline:9896d67. It will expire after two weeks.

@msherif1234 msherif1234 changed the title WIP NETOBSERV-1063: Add TCP drop to flowlogs-pipeline WIP NETOBSERV-1063: Add TCP drop & DNS tracking to flowlogs-pipeline Jun 4, 2023
@jpinsonneau jpinsonneau mentioned this pull request Jun 6, 2023
Merged
@msherif1234
Adding DNS tracker flowlogs changes
149e942 
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jun 6, 2023
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jun 6, 2023
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

New image: quay.io/netobserv/flowlogs-pipeline:d2a4cf5. It will expire after two weeks.

@msherif1234
flatten ICMP structure and rename tcpdrop fields
3598338 
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jun 20, 2023
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jun 20, 2023
@github-actions
Copy link

New image: quay.io/netobserv/flowlogs-pipeline:e6105d3. It will expire after two weeks.

@jpinsonneau jpinsonneau mentioned this pull request Jun 21, 2023
Closed
6 tasks
@msherif1234
update go mod and vendors with latest netobserv-agent
1b22a95 
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jun 24, 2023
@msherif1234 msherif1234 changed the title WIP NETOBSERV-1063: Add TCP drop & DNS tracking to flowlogs-pipeline NETOBSERV-1063: Add TCP drop & DNS tracking to flowlogs-pipeline Jun 24, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jun 24, 2023 •
edited by openshift-ci bot

@msherif1234: This pull request references NETOBSERV-1063 which is a valid jira issue.

In response to this:

add TCPDrop and DNS tracking support
flatten ICMP fields

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm label Jun 26, 2023
@jotak
Copy link
Member

jotak commented Jun 26, 2023

/lgtm

@jpinsonneau
Copy link
Collaborator

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 44f6fd9 into netobserv:main Jun 26, 2023
7 checks passed
@jpinsonneau jpinsonneau added the breaking-change This pull request has breaking changes. They should be described in PR description. label Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpinsonneau jpinsonneau jpinsonneau approved these changes

@ronensc ronensc Awaiting requested review from ronensc

Assignees

@jotak jotak

@jpinsonneau jpinsonneau

Labels
approved breaking-change This pull request has breaking changes. They should be described in PR description. jira/valid-reference lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@msherif1234 @openshift-ci-robot @jotak @jpinsonneau @openshift-merge-robot