-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1061: Add TCP drop and DNS tracking hooks #115
Conversation
Codecov Report
@@ Coverage Diff @@
## main #115 +/- ##
==========================================
- Coverage 40.48% 40.11% -0.38%
==========================================
Files 31 31
Lines 2060 2124 +64
==========================================
+ Hits 834 852 +18
- Misses 1186 1227 +41
- Partials 40 45 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@msherif1234: This pull request references NETOBSERV-979 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@msherif1234: This pull request references NETOBSERV-979 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@msherif1234: This pull request references NETOBSERV-979 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@msherif1234: This pull request references NETOBSERV-979 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@msherif1234: This pull request references NETOBSERV-979 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @praveingk @jotak @jpinsonneau @ronensc |
New image: ["quay.io/netobserv/netobserv-ebpf-agent:8197b19"]. It will expire after two weeks. |
@msherif1234 I tried to deploy this on a clusterbot using
I thought using
Am I missing something ? |
Yes similar to what I added to e2e manifests we need to add the same mount volume to the crd |
@msherif1234: This pull request references NETOBSERV-979 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@msherif1234: This pull request references NETOBSERV-979 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/ok-to-test |
/ok-to-test |
New image: quay.io/netobserv/netobserv-ebpf-agent:5aac091. It will expire after two weeks. |
/lgtm |
} else if (id->eth_protocol == ETH_P_IPV6) { | ||
*family = AF_INET6; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not urgent for this commit but there's functionality being repeated in these functions and the fill_**
functions so maybe we should look to just consolidate them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure we can do so
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
fix lint errors flatten icmp block Signed-off-by: msherif1234 <mmahmoud@redhat.com>
/ok-to-test |
New image: quay.io/netobserv/netobserv-ebpf-agent:cfcda6b. It will expire after two weeks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add skb_free tracepoint hook to detect when TCP flows are dropped and update flow metrics with tcp socket info.
To view ebpf tracepoints with
bpftool
For reference about tcpdrop https://www.brendangregg.com/blog/2018-05-31/linux-tcpdrop.html
Steps for manual testing using flowsdump collector tool
============================
once the drop iptable rule is installed we can see tcpdrop stats been updated
net_dev_queue
trace point hook to implement light weight DNS trackerdig google.coom
NOTE:
https://elixir.bootlin.com/linux/latest/source/include/net/dropreason-core.h#L88
Related PRs:
netobserv/network-observability-operator#331
netobserv/flowlogs-pipeline#429
netobserv/network-observability-console-plugin#324