-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-915 skip reinterpret direction for conversations #430
Conversation
Codecov Report
@@ Coverage Diff @@
## main #430 +/- ##
==========================================
+ Coverage 64.74% 64.75% +0.01%
==========================================
Files 94 94
Lines 6651 6654 +3
==========================================
+ Hits 4306 4309 +3
Misses 2102 2102
Partials 243 243
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/ok-to-test |
New image: quay.io/netobserv/flowlogs-pipeline:ef3ec70. It will expire after two weeks. |
New image: quay.io/netobserv/flowlogs-pipeline:b5b03e5. It will expire after two weeks. |
/ok-to-test |
/label qe-approved |
Just to clarify: are we safe doing so just because the "Reporter" field is anyway disabled in UI for Conversation views? I'm asking because, else, it's not very clear to me why we would skip reinterpret for conntrack. It was added because the concept of INGRESS/EGRESS direction, provided be the ebpf agent, is bound to an interface and not to the whole node as expected with our "Reporter" definition (well explained by Mario here: https://issues.redhat.com/browse/NETOBSERV-696?focusedId=21315152&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-21315152 ) So the "reinterpret" is a way to "normalize" what we consider as ingress or egress, and I don't see why it should be different with conntrack events - but if the "Reporter" setting is disabled anyway for conntrack, then I guess that's ok PS: I wonder if doing the "reinterpret" before processing conntrack wouldn't have also fixed the issues that we had |
/lgtm |
The goal is to enable it netobserv/network-observability-operator#313
As far as I have seen in my tests, it conflicts with the swapAB capability as it just update src / dst but doesn't affect Direction / IfDirection.
Why don't we do that reinterpretation in eBPF agent ? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpinsonneau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Skip
reinterpretDirection
for conversation events as source and destination can be swapped by TCP flagSYN_ACK
interpretation.Related PRs: