Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NETOBSERV-915 add conversation direction #317

Merged
merged 3 commits into from
Jun 8, 2023
Merged

NETOBSERV-915 add conversation direction #317

merged 3 commits into from
Jun 8, 2023

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Mar 30, 2023 •
edited

This PR adds direction fields to conversation tracking

Also, it adds JSON fields sorting to be able to easy compare 2 items

Related PRs:

@jpinsonneau jpinsonneau mentioned this pull request Mar 30, 2023
Merged
@codecov
Copy link

codecov bot commented Mar 30, 2023 •
edited

Codecov Report

Merging #317 (b8b1ee6) into main (8a60339) will increase coverage by 0.04%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##             main     #317      +/-   ##
==========================================
+ Coverage   57.83%   57.87%   +0.04%     
==========================================
  Files         150      150              
  Lines        6652     6657       +5     
  Branches      795      797       +2     
==========================================
+ Hits         3847     3853       +6     
  Misses       2588     2588              
+ Partials      217      216       -1
Flag Coverage Δ
uitests 58.83% <62.50%> (+0.06%) ⬆️
unittests 55.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/components/dropdowns/query-options-dropdown.tsx 84.84% <0.00%> (ø)
web/src/components/netflow-traffic.tsx 53.53% <ø> (ø)
web/src/utils/columns.ts 65.66% <50.00%> (-0.14%) ⬇️
web/src/components/netflow-record/record-panel.tsx 67.77% <100.00%> (+1.11%) ⬆️

... and 1 file with indirect coverage changes

@jpinsonneau
Copy link
Contributor Author

/hold

@jpinsonneau jpinsonneau marked this pull request as ready for review March 31, 2023 08:14
@jpinsonneau
Copy link
Contributor Author

/hold

@jpinsonneau jpinsonneau mentioned this pull request Apr 4, 2023
Open
@Amoghrd
Copy link
Contributor

Amoghrd commented Apr 24, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 24, 2023
@github-actions
Copy link

New image: ["quay.io/netobserv/network-observability-console-plugin:a95dab2"]. It will expire after two weeks.

@jpinsonneau jpinsonneau mentioned this pull request May 3, 2023
Merged
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 3, 2023
@jpinsonneau
Copy link
Contributor Author

Addressed feedback on json sort + include _RecordType as secondary criteria to sort start / end time columns to ensure start < tick < end order when logs have exact same time:

image

@Amoghrd
Copy link
Contributor

Amoghrd commented May 4, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 4, 2023
@github-actions
Copy link

github-actions bot commented May 4, 2023

New image: ["quay.io/netobserv/network-observability-console-plugin:0fca691"]. It will expire after two weeks.

@jpinsonneau jpinsonneau added ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. and removed ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. labels May 25, 2023
@github-actions
Copy link

New image: quay.io/netobserv/network-observability-console-plugin:2ece72c. It will expire after two weeks.

@jpinsonneau jpinsonneau requested a review from jotak May 25, 2023 12:05
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 26, 2023
@Amoghrd
Copy link
Contributor

Amoghrd commented May 30, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 30, 2023
@github-actions
Copy link

New image: quay.io/netobserv/network-observability-console-plugin:9a58866. It will expire after two weeks.

@Amoghrd
Copy link
Contributor

Amoghrd commented Jun 1, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Jun 1, 2023
@openshift-ci openshift-ci bot added the lgtm label Jun 2, 2023
@jpinsonneau jpinsonneau mentioned this pull request Jun 8, 2023
Merged
@jpinsonneau
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 8, 2023
@openshift-merge-robot openshift-merge-robot merged commit c855cf2 into netobserv:main Jun 8, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jotak jotak jotak approved these changes

@OlivierCazade OlivierCazade Awaiting requested review from OlivierCazade

Assignees

@jotak jotak

Labels
approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jpinsonneau @Amoghrd @jotak @openshift-merge-robot