Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1190: update DNS tracking to report latency instead of TS #455

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

msherif1234
Copy link
Contributor

No description provided.

Signed-off-by: msherif1234 <mmahmoud@redhat.com>
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jul 13, 2023

@msherif1234: This pull request references NETOBSERV-1190 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #455 (d2f7e7a) into main (4e3576e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
- Coverage   62.69%   62.69%   -0.01%     
==========================================
  Files          96       96              
  Lines        6970     6969       -1     
==========================================
- Hits         4370     4369       -1     
  Misses       2356     2356              
  Partials      244      244              
Flag Coverage Δ
unittests 62.69% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/pipeline/decode/decode_protobuf.go 29.55% <100.00%> (-0.25%) ⬇️

@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 14, 2023
@github-actions
Copy link

New image: quay.io/netobserv/flowlogs-pipeline:620cc7d. It will expire after two weeks.

@jotak
Copy link
Member

jotak commented Jul 17, 2023

/lgtm
/hold
holding to wait for dependent PRs

Signed-off-by: msherif1234 <mmahmoud@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Jul 17, 2023
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 17, 2023
@msherif1234 msherif1234 changed the title WIP: NETOBSERV-1190: update DNS tracking to report latency instead of TS NETOBSERV-1190: update DNS tracking to report latency instead of TS Jul 17, 2023
@jotak
Copy link
Member

jotak commented Jul 17, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 17, 2023
@msherif1234
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak
Copy link
Member

jotak commented Jul 17, 2023

/unhold

@openshift-merge-robot openshift-merge-robot merged commit 84df140 into netobserv:main Jul 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants