Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1190: change DNS to use latency instead of TS #395

Merged
merged 9 commits into from
Jul 17, 2023

Conversation

msherif1234 and others added 8 commits July 13, 2023 12:52
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
when creating ebpf pod in privileged mode we
got Error creating: pods "netobserv-ebpf-agent-"
is forbidden: unable to validate against any
security context constraint

Signed-off-by: msherif1234 <mmahmoud@redhat.com>
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jul 14, 2023

@msherif1234: This pull request references NETOBSERV-1190 which is a valid jira issue.

In response to this:

This PR need to be merged once

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 14, 2023
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #395 (509b659) into main (a4a3c26) will decrease coverage by 0.85%.
The diff coverage is 51.79%.

❗ Current head 509b659 differs from pull request most recent head 97cd9d0. Consider uploading reports for the commit 97cd9d0 to get more accurate results

@@            Coverage Diff             @@
##             main     #395      +/-   ##
==========================================
- Coverage   54.52%   53.67%   -0.85%     
==========================================
  Files          44       44              
  Lines        5423     5559     +136     
==========================================
+ Hits         2957     2984      +27     
- Misses       2259     2360     +101     
- Partials      207      215       +8     
Flag Coverage Δ
unittests 53.67% <51.79%> (-0.85%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/v1alpha1/flowcollector_webhook.go 0.00% <0.00%> (ø)
api/v1alpha1/zz_generated.conversion.go 0.26% <0.00%> (+<0.01%) ⬆️
api/v1beta1/flowcollector_types.go 100.00% <ø> (ø)
...ntrollers/ebpf/internal/permissions/permissions.go 44.18% <0.00%> (-2.44%) ⬇️
controllers/consoleplugin/consoleplugin_objects.go 95.42% <33.33%> (-1.64%) ⬇️
pkg/helper/flowcollector.go 66.66% <40.00%> (-3.47%) ⬇️
controllers/flowlogspipeline/flp_common_objects.go 81.76% <53.48%> (-4.83%) ⬇️
controllers/ebpf/agent_controller.go 70.70% <58.77%> (-10.36%) ⬇️
api/v1beta1/zz_generated.deepcopy.go 53.77% <100.00%> (+1.05%) ⬆️

... and 1 file with indirect coverage changes

@github-actions
Copy link

New images:

  • quay.io/netobserv/network-observability-operator:70e53a0
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-70e53a0
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-70e53a0

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:70e53a0 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-70e53a0

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-70e53a0
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@jotak
Copy link
Member

jotak commented Jul 17, 2023

/lgtm
But with a suggestion: msherif1234#1

@openshift-ci openshift-ci bot added lgtm and removed lgtm labels Jul 17, 2023
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 17, 2023
@jotak
Copy link
Member

jotak commented Jul 17, 2023

thanks!
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 17, 2023
@jotak
Copy link
Member

jotak commented Jul 17, 2023

@msherif1234 you need to run make update-bundle

This PR depends on PR netobserv#331 so 331 need to be merged 1st

Signed-off-by: msherif1234 <mmahmoud@redhat.com>
@jotak
Copy link
Member

jotak commented Jul 17, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Jul 17, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 00caab5 into netobserv:main Jul 17, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants