Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1197: Generalize TCPDrop to support more protocols #457

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

msherif1234
Copy link
Contributor

@msherif1234 msherif1234 commented Jul 17, 2023

netobserv/netobserv-ebpf-agent#152 needs to be merged 1st then update netobserv-agent with the commit id

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #457 (0f86aa5) into main (f771d4b) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
- Coverage   66.20%   66.17%   -0.03%     
==========================================
  Files          94       94              
  Lines        6808     6808              
==========================================
- Hits         4507     4505       -2     
- Misses       2046     2047       +1     
- Partials      255      256       +1     
Flag Coverage Δ
unittests 66.17% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/pipeline/decode/decode_protobuf.go 29.55% <100.00%> (ø)

... and 1 file with indirect coverage changes

@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 17, 2023
@github-actions
Copy link

New image: quay.io/netobserv/flowlogs-pipeline:8deb6f9. It will expire after two weeks.

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 17, 2023
@msherif1234 msherif1234 changed the title WIP: Generalize TCPDrop to support more protocols WIP: NETOBSERV-1197: Generalize TCPDrop to support more protocols Jul 17, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jul 17, 2023

@msherif1234: This pull request references NETOBSERV-1197 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jul 18, 2023

@msherif1234: This pull request references NETOBSERV-1197 which is a valid jira issue.

In response to this:

netobserv/netobserv-ebpf-agent#152 needs to be merged 1st then update netobserv-agent with the commit id

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Amoghrd
Copy link
Contributor

Amoghrd commented Jul 18, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 18, 2023
@github-actions
Copy link

New image: quay.io/netobserv/flowlogs-pipeline:5209b52. It will expire after two weeks.

@dushyantbehl
Copy link
Contributor

dushyantbehl commented Jul 19, 2023

/lgtm

Seems just a rename

@dushyantbehl
Copy link
Contributor

@msherif1234 seems okay but there is a WIP tag with the PR heading.

@msherif1234
Copy link
Contributor Author

@msherif1234 seems okay but there is a WIP tag with the PR heading.

Thanks @dushyantbehl yeah it need to be updated with ebpf PR commit id

Signed-off-by: msherif1234 <mmahmoud@redhat.com>
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 19, 2023
@msherif1234 msherif1234 changed the title WIP: NETOBSERV-1197: Generalize TCPDrop to support more protocols NETOBSERV-1197: Generalize TCPDrop to support more protocols Jul 19, 2023
@jotak
Copy link
Member

jotak commented Jul 19, 2023

/lgtm

@dushyantbehl
Copy link
Contributor

/lgtm

@msherif1234
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9290c93 into netobserv:main Jul 19, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants