Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1197: Generalize TCPDrop to include other protocols #152

Merged
merged 1 commit into from
Jul 19, 2023
Merged

NETOBSERV-1197: Generalize TCPDrop to include other protocols #152

merged 1 commit into from
Jul 19, 2023

Conversation

msherif1234
Copy link
Contributor

skb_free hook also capture other protocols
packets dropped not only TCP

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #152 (fa8625d) into main (bf7d160) will not change coverage.
The diff coverage is 52.63%.

@@           Coverage Diff           @@
##             main     #152   +/-   ##
=======================================
  Coverage   39.25%   39.25%           
=======================================
  Files          31       31           
  Lines        2214     2214           
=======================================
  Hits          869      869           
  Misses       1296     1296           
  Partials       49       49           
Flag Coverage Δ
unittests 39.25% <52.63%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/agent.go 37.84% <0.00%> (ø)
pkg/ebpf/tracer.go 0.00% <0.00%> (ø)
pkg/exporter/proto.go 95.12% <100.00%> (ø)

@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 17, 2023
@github-actions
Copy link

New image:
quay.io/netobserv/netobserv-ebpf-agent:479e53e

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=479e53e make set-agent-image

@msherif1234 msherif1234 changed the title Generalize TCPDrop to include other protocols NETOBSERV-1197: Generalize TCPDrop to include other protocols Jul 17, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jul 17, 2023

@msherif1234: This pull request references NETOBSERV-1197 which is a valid jira issue.

In response to this:

skb_free hook also capture other protocols
packets dropped not only TCP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

skb_free hook also capture other protocols
packets dropped not only TCP

Signed-off-by: msherif1234 <mmahmoud@redhat.com>
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 18, 2023
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 18, 2023
@github-actions
Copy link

New image:
quay.io/netobserv/netobserv-ebpf-agent:36a85ee

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=36a85ee make set-agent-image

@dushyantbehl
Copy link
Contributor

/lgtm

@msherif1234
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 31526a9 into netobserv:main Jul 19, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved jira/valid-reference lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants