-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1101: support [Mutual] TLS for grpc server #469
base: main
Are you sure you want to change the base?
Conversation
@jotak: This pull request references NETOBSERV-1101 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
not tested yet end to end |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Since mtls is quite symetric, I wonder if it still makes sense to have dedicated structs for ClientTLS and ServerTLS, or if we should merge them ... |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #469 +/- ##
==========================================
- Coverage 66.15% 66.06% -0.10%
==========================================
Files 94 95 +1
Lines 6867 6960 +93
==========================================
+ Hits 4543 4598 +55
- Misses 2065 2088 +23
- Partials 259 274 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@jotak: This pull request references NETOBSERV-1101 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Related PRs:
Breaking change:
The Client TLS configuration API changes (previously used only for Kafka):
ClientTLS
toTLSConfig
TLSConfig
APItype
can benone
,simple
ormutual
. If you were previously using TLS, set it tosimple
for 1-1 migration. Empty defaults tonone
.userCertPath
=>certPath
userKeyPath
=>keyPath