Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1101: secure GRPC connection #166

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jotak
Copy link
Member

@jotak jotak commented Jul 31, 2023

  • Add TLS and mTLS configuration to allow secure GRPC (when not using Kafka), on the same model than Kafka TLS
  • Log a warning when insecure is used

(opening as draft as I did not test yet)

Related PRs:

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jul 31, 2023

@jotak: This pull request references NETOBSERV-1101 which is a valid jira issue.

In response to this:

  • Add TLS and mTLS configuration to allow secure GRPC (when not using Kafka), on the same model than Kafka TLS
  • Log a warning when insecure is used

(opening as draft as I did not test yet)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

- Add TLS and mTLS configuration to allow secure GRPC (when not using
  Kafka), on the same model than Kafka TLS
- Log a warning when insecure is used
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #166 (7fda953) into main (8150ccc) will decrease coverage by 0.34%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
- Coverage   38.66%   38.33%   -0.34%     
==========================================
  Files          31       31              
  Lines        2255     2280      +25     
==========================================
+ Hits          872      874       +2     
- Misses       1334     1355      +21     
- Partials       49       51       +2     
Flag Coverage Δ
unittests 38.33% <20.00%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/agent/agent.go 37.07% <0.00%> (-0.78%) ⬇️
pkg/agent/tls.go 0.00% <0.00%> (ø)
pkg/grpc/client.go 61.90% <66.66%> (-6.85%) ⬇️
pkg/exporter/grpc_proto.go 73.91% <100.00%> (ø)

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Aug 1, 2023

@jotak: This pull request references NETOBSERV-1101 which is a valid jira issue.

In response to this:

  • Add TLS and mTLS configuration to allow secure GRPC (when not using Kafka), on the same model than Kafka TLS
  • Log a warning when insecure is used

(opening as draft as I did not test yet)

Related PRs:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants