Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using LRU hashmap because they consume lots of memory #162

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Avoid using LRU hashmap because they consume lots of memory #162

merged 1 commit into from
Jul 21, 2023

Conversation

msherif1234
Copy link
Contributor

@msherif1234 msherif1234 commented Jul 21, 2023 •
edited

Even when the feature is not on memory with latest showing double the normal use

Note: In general relying on LRU to evict old entries isn;t recommended because its hard to perdict when an entry will be deleted
at somepoint we need to add eviction logic in userspace

latest_perf

@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 21, 2023
@github-actions
Copy link

New image:
quay.io/netobserv/netobserv-ebpf-agent:869b593

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=869b593 make set-agent-image

@codecov
Copy link

codecov bot commented Jul 21, 2023 •
edited

Codecov Report

Merging #162 (afb0d58) into main (31526a9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   39.25%   39.25%           
=======================================
  Files          31       31           
  Lines        2214     2214           
=======================================
  Hits          869      869           
  Misses       1296     1296           
  Partials       49       49
Flag Coverage Δ
unittests 39.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 21, 2023
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 21, 2023
@github-actions
Copy link

New image:
quay.io/netobserv/netobserv-ebpf-agent:87b9565

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=87b9565 make set-agent-image

@msherif1234
Avoid using LRU hashmap because they needs lots of memory
afb0d58 
Even when the feature is not on memory with latest
showing double the normal use

Note: In general relying on LRU to evict old entries
isn;t recommended because its hard to perdict when
an entry will be deleted
at somepoint we need to add eviction logic in userspace

Signed-off-by: msherif1234 <mmahmoud@redhat.com>
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 21, 2023
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 21, 2023
@github-actions
Copy link

New image:
quay.io/netobserv/netobserv-ebpf-agent:edf5d1b

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=edf5d1b make set-agent-image

dushyantbehl
dushyantbehl approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@dushyantbehl dushyantbehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to do. LRU is taking too much memory.
Userspace eviction can be added later for stale entries.

@openshift-ci openshift-ci bot added the lgtm label Jul 21, 2023
@dushyantbehl
Copy link
Contributor

/lgtm

@msherif1234 msherif1234 changed the title Avoid using LRU hashmap because they needs lots of memory Avoid using LRU hashmap because they consume lots of memory Jul 21, 2023
@msherif1234
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d3f035d into netobserv:main Jul 21, 2023
10 checks passed
@msherif1234 msherif1234 mentioned this pull request Jul 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dushyantbehl dushyantbehl dushyantbehl approved these changes

Assignees

@dushyantbehl dushyantbehl

Labels
approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@msherif1234 @dushyantbehl @openshift-merge-robot