-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid using LRU hashmap because they consume lots of memory #162
Conversation
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=869b593 make set-agent-image |
Codecov Report
@@ Coverage Diff @@
## main #162 +/- ##
=======================================
Coverage 39.25% 39.25%
=======================================
Files 31 31
Lines 2214 2214
=======================================
Hits 869 869
Misses 1296 1296
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more. |
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=87b9565 make set-agent-image |
Even when the feature is not on memory with latest showing double the normal use Note: In general relying on LRU to evict old entries isn;t recommended because its hard to perdict when an entry will be deleted at somepoint we need to add eviction logic in userspace Signed-off-by: msherif1234 <mmahmoud@redhat.com>
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=edf5d1b make set-agent-image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to do. LRU is taking too much memory.
Userspace eviction can be added later for stale entries.
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Even when the feature is not on memory with latest showing double the normal use
Note: In general relying on LRU to evict old entries isn;t recommended because its hard to perdict when an entry will be deleted
at somepoint we need to add eviction logic in userspace