-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to evict DNS and RTT stale entries #163
Add support to evict DNS and RTT stale entries #163
Conversation
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=b57d218 make set-agent-image |
Codecov Report
@@ Coverage Diff @@
## main #163 +/- ##
==========================================
- Coverage 39.25% 38.82% -0.43%
==========================================
Files 31 31
Lines 2214 2246 +32
==========================================
+ Hits 869 872 +3
- Misses 1296 1325 +29
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@msherif1234 can we add a check here like clear the entries which are 5s/10s earlier and are still there (which means they are stale I mean)? |
e0eb7c1
to
12edd0f
Compare
0115f58
to
e5c0c39
Compare
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=adfe386 make set-agent-image |
Thanks @msherif1234 for adding the timeout. I just feel one small thing that since we are handling three maps with one funciton maybe we can make a map manager and handle all three inside of it.. other than that looks good to me. |
e5c0c39
to
cf715b7
Compare
I created new interface to handle features map I think is more cleaner WDYT ? |
Signed-off-by: msherif1234 <mmahmoud@redhat.com>
cf715b7
to
3cae3e5
Compare
Looks good to me thanks! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Its possible we can have DNS queries w/o any responses or RTT entries w/o replies those entries will be there for ever, since we can't use LRU because we don't know when entries will be deleted and its very large memory footprint we will evict those entries in the user space every time we evict flows hash table by default every 5 seconds.
This is follow up for #162
No CPU or memory obvious impact with this PR
![image](https://private-user-images.githubusercontent.com/12748167/255340963-1180f0c9-80e2-43bc-a666-02ac181d569f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ0NjM5MjcsIm5iZiI6MTcyNDQ2MzYyNywicGF0aCI6Ii8xMjc0ODE2Ny8yNTUzNDA5NjMtMTE4MGYwYzktODBlMi00M2JjLWE2NjYtMDJhYzE4MWQ1NjlmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI0VDAxNDAyN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRhMjA0NDIyNGI0ZjUyYjM3NmQwNTJkMmViMTE2NzJjMDQ3YTViMjdlYjBhODk0ZjNjZWQ3ZDYzMzY3ZjYzZGMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.qQeIkKaegTiR8zpGiudFHbMBTZ0T68UUpyd67L-XNa0)