-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change HOST/PORT env to TARGET_HOST / TARGET_PORT #303
Conversation
As discussed here: netobserv#291 (comment) HOST and PORT are very generic and don't provide the meaning about what they are for; An uninformed user would probably think this would be for a server, of for the agent host itself, rather than a target of flow/packet collectors.
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=ff5ff28 make set-agent-image |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #303 +/- ##
=======================================
Coverage 34.04% 34.04%
=======================================
Files 47 47
Lines 3836 3836
=======================================
Hits 1306 1306
Misses 2444 2444
Partials 86 86
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sure, thanks for the update @jotak |
As discussed here: #291 (comment) HOST and PORT are very generic and don't provide the meaning about what they are for; An uninformed user would probably think this would be for a server, or for the agent host itself, rather than a target of flow/packet collectors.
Description
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.