Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-397 Implement TLS for Kafka connection in the agent #44

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

jotak
Copy link
Member

@jotak jotak commented Jul 13, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2022

Codecov Report

Merging #44 (6b2189b) into main (83db69e) will decrease coverage by 1.58%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   46.89%   45.31%   -1.59%     
==========================================
  Files          16       17       +1     
  Lines        1032     1068      +36     
==========================================
  Hits          484      484              
- Misses        524      560      +36     
  Partials       24       24              
Flag Coverage Δ
unittests 45.31% <0.00%> (-1.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/agent.go 67.72% <0.00%> (-3.00%) ⬇️
pkg/agent/tls.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83db69e...6b2189b. Read the comment docs.

mariomac
mariomac previously approved these changes Jul 27, 2022
Copy link

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

It would be nice to also keep this file up to date with the new configuration: https://github.com/netobserv/netobserv-ebpf-agent/blob/main/docs/config.md

@jotak
Copy link
Member Author

jotak commented Aug 1, 2022

@mariomac config.md updated

@jotak jotak requested a review from mariomac August 1, 2022 09:37
@jotak jotak merged commit 036919c into netobserv:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants