Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-787 UI: Table Histogram #271

Merged
merged 3 commits into from
Jan 31, 2023
Merged

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Jan 16, 2023

This implements histogram UI component based on #270 query.

The range is forced while selecting if at least next histogram bar (or more) is less than selected limit:
image

Increasing the limit allows you to select more at once:
image

Else the range selection is free and limit will be hit as usual as you can see in the bottom bar:
image

ToDos:

  • disable auto range selection when limit is reached at first step
  • improve default query (range not selected) => keeping the default behavior and showing preview in the histogram for now
  • show start / end as tooltips

Knowns bugs:

  • can't select range from first click. You need to focus on another element (clic on Traffic flows tab for example) before selecting range
  • histogram count mismatch summary count

Followups:

@openshift-ci
Copy link

openshift-ci bot commented Jan 16, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Jan 16, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jpinsonneau by writing /assign @jpinsonneau in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Collaborator

@OlivierCazade OlivierCazade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrew-ronaldson
Copy link

I'd like to tweak the visuals a bit. I'll send something shortly

@jpinsonneau
Copy link
Contributor Author

I'd like to tweak the visuals a bit. I'll send something shortly

Sure @andrew-ronaldson, waiting for your feedback before merging this. Thanks !

@jpinsonneau
Copy link
Contributor Author

Let's merge this and do the UI tweaks in a followup. I'd like to unlock #272

/approve

@jpinsonneau jpinsonneau merged commit 6877d5e into netobserv:main Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants