Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-789 UI: Table Histogram shortcuts #272

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Jan 19, 2023

This improves histogram user experience by adding buttons and keyboards shortcuts for the following actions:

  • move range previous / next
    • binded to left and right arrow keys
  • zoom / unzoom range
    • binded to minus and plus buttons
  • move histogram selection previous / next
    • binded to page up and down

image

To let the user better understand what's happening, the custom time range label has been replaced by actual values.

image

Also I suggest to decrease default limit to 50 as queries will be faster and this new method allows a better navigation. The best option for me would be to replace the current selector by a number input in a followup

image

based on #271

@openshift-ci
Copy link

openshift-ci bot commented Jan 19, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jpinsonneau
Copy link
Contributor Author

/hold for #271

@jpinsonneau
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 24, 2023
@github-actions
Copy link

New image: ["quay.io/netobserv/network-observability-console-plugin:7b71b24"]. It will expire after two weeks.

@jpinsonneau
Copy link
Contributor Author

/unhold

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 31, 2023
@jpinsonneau
Copy link
Contributor Author

@jotak @OlivierCazade I have merged #271 and rebased this PR so you can review these extra changes when you have some time

@andrew-ronaldson feel free to give your feedback here or in a followup

Thank you !

@Amoghrd
Copy link
Contributor

Amoghrd commented Jan 31, 2023

/ok-to-test

@Amoghrd
Copy link
Contributor

Amoghrd commented Jan 31, 2023

/label ok-to-test

@Amoghrd
Copy link
Contributor

Amoghrd commented Feb 1, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 1, 2023
@github-actions
Copy link

github-actions bot commented Feb 1, 2023

New image: ["quay.io/netobserv/network-observability-console-plugin:8e810b0"]. It will expire after two weeks.

@Amoghrd
Copy link
Contributor

Amoghrd commented Feb 1, 2023

So @jpinsonneau The <> arrows moves the datapoints by 2 mins; <<>> arrows move the time range by 15 minutes and +- moves the time range by 30 minutes. thats the expected behavior right?
But one nit, the custom time range field can only take values which are given in the dropdown(which is every 30 mins), something like 14:22:23 cannot be one given as inputs.

@jpinsonneau
Copy link
Contributor Author

So @jpinsonneau The <> arrows moves the datapoints by 2 mins; <<>> arrows move the time range by 15 minutes and +- moves the time range by 30 minutes. thats the expected behavior right?

Well these values are not fixed; it's context related:

  • <> shift the selection inside the histogram and try to avoid limit reached by adapting the new width. If it can't, it will keep the previous selection width.
  • <<>> move the time range by currently selected range on top right corner time range dropdown (Last 15 minutes in your example)
  • +- select previous / next item in the list of the top right corner time range dropdown

But one nit, the custom time range field can only take values which are given in the dropdown(which is every 30 mins), something like 14:22:23 cannot be one given as inputs.

I'm not sure to get that point. Custom time range is fully free. You can pick any value there and the histogram shortcuts will do so.

@Amoghrd
Copy link
Contributor

Amoghrd commented Feb 2, 2023

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Feb 2, 2023
Copy link
Collaborator

@OlivierCazade OlivierCazade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, my comment was more a general comment

@@ -1005,6 +1007,70 @@ export const NetflowTraffic: React.FC<{
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [match, filters]);

const moveRange = React.useCallback(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More a general comment here.
In my opinion, NetflowTraffic has become too big and we should split it for maintainability.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fully aligned with that. I'm planning to move the drawer away as I did in my PoC on connection tracking.

We can also move the modals away from that file creating a dedicated component.

I'm adding a note in https://issues.redhat.com/browse/NETOBSERV-268 to keep track.

@jpinsonneau
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Feb 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 8, 2023
@openshift-merge-robot openshift-merge-robot merged commit 4b64177 into netobserv:main Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants