-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-765 Restore metrics #315
Conversation
Hey @OlivierCazade @jpinsonneau , |
How hard is it to implement ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be changes in go.mod
and go.sum
files right?
Another possibility would be to serve the metrics on a different port. |
No change there, prometheus is already imported, there's just a couple more files being used hence added to vendors |
@OlivierCazade I implemented your suggestion; see also netobserv/network-observability-operator#310 |
Codecov Report
@@ Coverage Diff @@
## main #315 +/- ##
==========================================
- Coverage 58.31% 58.08% -0.24%
==========================================
Files 148 149 +1
Lines 6592 6615 +23
Branches 792 792
==========================================
- Hits 3844 3842 -2
- Misses 2531 2556 +25
Partials 217 217
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/ok-to-test |
New image: ["quay.io/netobserv/network-observability-console-plugin:59a7515"]. It will expire after two weeks. |
@jotak - I tested this with plugin image listed here and used NOO image from PR: netobserv/network-observability-operator#310. I enabled user workload monitoring, but I am not able to see plugin metrics being scraped, in below screenshot you can find metrics from just FLP container, anything I am missing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
New changes are detected. LGTM label has been removed. |
@memodi I retried this morning and it worked for me. Same steps as you: deploy my operator PR image, set this console plugin image, enable user workload monitoring... wait a minute or so to get metrics populated, and they are: Also if you trigger some queries to Loki via the console plugin, you should get dedicated metrics such as If you retry, could you check the Targets page to see if the console plugin is listed and w/o errors? |
New image: ["quay.io/netobserv/network-observability-console-plugin:9bfd9ec"]. It will expire after two weeks. |
yes, I can see those metrics today. Not sure what I had missed other day. Anyway, thank you for checking. /label qe-approved |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.