-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-765 Add CA/Secret config to ServiceMonitor #310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -532,7 +532,7 @@ type FlowCollectorConsolePlugin struct { | |||
//+kubebuilder:validation:Minimum=1 | |||
//+kubebuilder:validation:Maximum=65535 | |||
//+kubebuilder:default:=9001 | |||
// port is the plugin service port | |||
// port is the plugin service port. Do not use 9002, which is reserved for metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I didn't want to add a new port config to the CRD, I think it brings very little value if any, while bloating the CRD with new configs ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need a //+kubebuilder:validation
to exclude 9002 ? Maybe using a pattern
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jotak while we're at it, do you think it would be good idea to address this: https://issues.redhat.com/browse/NETOBSERV-511 ?
Codecov Report
@@ Coverage Diff @@
## main #310 +/- ##
==========================================
+ Coverage 51.34% 51.53% +0.18%
==========================================
Files 43 43
Lines 5155 5156 +1
==========================================
+ Hits 2647 2657 +10
+ Misses 2310 2304 -6
+ Partials 198 195 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/ok-to-test |
New images:
They will expire after two weeks. Catalog source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-bca9db7
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
Add missing CA/Secret to the console plugin service monitor
Some refactoring to normalize services reconciliation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
New images:
They will expire after two weeks. Catalog source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-7fe73cd
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add missing CA/Secret to the console plugin service monitor
Cf netobserv/network-observability-console-plugin#315
We might also want to add a bearer token config