Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate documentation with conntrack changes #321

Merged
merged 3 commits into from
Apr 6, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Apr 5, 2023

No description provided.

_IsFirst?: string;
/** In conversation tracking, a counter of flow logs */
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jpinsonneau @ronensc : is this accurate, this is the number of flows already accumulated in a conversation?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes 👍 good to me

@jotak
Copy link
Member Author

jotak commented Apr 5, 2023

cc @skrthomas

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #321 (a9c2291) into main (5155dc3) will decrease coverage by 1.83%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
- Coverage   58.41%   56.59%   -1.83%     
==========================================
  Files         148       28     -120     
  Lines        6581     1707    -4874     
  Branches      786        0     -786     
==========================================
- Hits         3844      966    -2878     
+ Misses       2520      653    -1867     
+ Partials      217       88     -129     
Flag Coverage Δ
uitests ?
unittests 56.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 120 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Comment on lines +95 to 96
/** In conversation tracking, a counter of flow logs per conversation */
numFlowLogs?: number;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to remove numFlowLogs here to hide it from doc and in columns.ts @jotak
This field is not displayed yet. We can rename / change it later.

skrthomas
skrthomas previously approved these changes Apr 5, 2023
Copy link
Contributor

@skrthomas skrthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Co-authored-by: Sara Thomas <sarthoma@redhat.com>
@jpinsonneau
Copy link
Contributor

/lgtm thanks @jotak !

@jotak
Copy link
Member Author

jotak commented Apr 6, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Apr 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 6, 2023
@openshift-merge-robot openshift-merge-robot merged commit bd576c7 into netobserv:main Apr 6, 2023
@skrthomas
Copy link
Contributor

@jotak will there be another PR with that has updated asciidoc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants