-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerate documentation with conntrack changes #321
Conversation
web/src/api/ipfix.ts
Outdated
_IsFirst?: string; | ||
/** In conversation tracking, a counter of flow logs */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jpinsonneau @ronensc : is this accurate, this is the number of flows already accumulated in a conversation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes 👍 good to me
cc @skrthomas |
Codecov Report
@@ Coverage Diff @@
## main #321 +/- ##
==========================================
- Coverage 58.41% 56.59% -1.83%
==========================================
Files 148 28 -120
Lines 6581 1707 -4874
Branches 786 0 -786
==========================================
- Hits 3844 966 -2878
+ Misses 2520 653 -1867
+ Partials 217 88 -129
Flags with carried forward coverage won't be shown. Click here to find out more. see 120 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
/** In conversation tracking, a counter of flow logs per conversation */ | ||
numFlowLogs?: number; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to remove numFlowLogs
here to hide it from doc and in columns.ts
@jotak
This field is not displayed yet. We can rename / change it later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Co-authored-by: Sara Thomas <sarthoma@redhat.com>
/lgtm thanks @jotak ! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jotak will there be another PR with that has updated asciidoc? |
No description provided.