Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update json doc #325

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Update json doc #325

merged 2 commits into from
Apr 11, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Apr 7, 2023

@openshift-ci
Copy link

openshift-ci bot commented Apr 7, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #325 (456ebd3) into main (e143bf6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #325   +/-   ##
=======================================
  Coverage   50.90%   50.90%           
=======================================
  Files          43       43           
  Lines        5080     5080           
=======================================
  Hits         2586     2586           
  Misses       2293     2293           
  Partials      201      201           
Flag Coverage Δ
unittests 50.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

skrthomas
skrthomas previously approved these changes Apr 7, 2023
Copy link
Contributor

@skrthomas skrthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm thanks Joel!

@skrthomas
Copy link
Contributor

@jotak I'm wondering about the following lines:
FlowDirection::
FlowDirection: <<Enumeration: FlowDirection,FlowDirection>>

These '<<>>' are throwing asciibinder errors. Can I do something like Enumeration: FlowDirection,FlowDirection instead? Or an alternative?

@openshift-ci
Copy link

openshift-ci bot commented Apr 11, 2023

New changes are detected. LGTM label has been removed.

@jotak
Copy link
Member Author

jotak commented Apr 11, 2023

@skrthomas as discussed: removed the link, replaced with a text

@jotak jotak merged commit 36de463 into netobserv:main Apr 11, 2023
@jotak jotak deleted the update-json-doc branch September 28, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants