-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1200 UI: DNSTracking feedback improvments #361
Conversation
Codecov Report
@@ Coverage Diff @@
## main #361 +/- ##
==========================================
- Coverage 57.50% 56.61% -0.89%
==========================================
Files 161 164 +3
Lines 7276 7614 +338
Branches 902 921 +19
==========================================
+ Hits 4184 4311 +127
- Misses 2846 3038 +192
- Partials 246 265 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Setting this PR as ready for review since it's already quite big |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM however the logic moreThanRegex
looks too complex but u added UT for it so should be stable we can improve after the PR is merged
/lgtm |
Yes I agree. If you have an easier approach in mind I'm in 😸 Else @jotak suggested to maintain a static list of value - regex for 1 / 10 / 100 ms. The downside is that it may not apply to any number fields in future. |
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=40ffaac make set-plugin-image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moreThan fails to match
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=9407a24 make set-plugin-image |
/label qe-approved |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpinsonneau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Followup https://issues.redhat.com/browse/NETOBSERV-1227