-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1241 Back and forth show the opposite #369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can u explain pros vs cons for this change ?
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpinsonneau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merging this as it impacts other debuging / testings |
New changes are detected. LGTM label has been removed. |
Codecov Report
@@ Coverage Diff @@
## main #369 +/- ##
==========================================
- Coverage 57.83% 57.30% -0.53%
==========================================
Files 166 167 +1
Lines 7679 7750 +71
Branches 918 918
==========================================
Hits 4441 4441
- Misses 2971 3042 +71
Partials 267 267
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I'm suggesting to simply invert
back and forth
&one way
texts.If it's not clear enough, we should think about a check box / a switch or a radio button instead