Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1241 Back and forth show the opposite #369

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

jpinsonneau
Copy link
Contributor

I'm suggesting to simply invert back and forth & one way texts.
If it's not clear enough, we should think about a check box / a switch or a radio button instead

Copy link
Contributor

@msherif1234 msherif1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can u explain pros vs cons for this change ?

@jpinsonneau
Copy link
Contributor Author

I don't think there are cons here. Just a matter of better UX.

Currently when 'back and forth' is shown, it's actually one way:
image
And vice versa:
image

@msherif1234
Copy link
Contributor

/lgtm

@jpinsonneau
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpinsonneau
Copy link
Contributor Author

Merging this as it impacts other debuging / testings

@openshift-ci openshift-ci bot removed the lgtm label Aug 21, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 21, 2023

New changes are detected. LGTM label has been removed.

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #369 (9cf5e63) into main (f2a289f) will decrease coverage by 0.53%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
- Coverage   57.83%   57.30%   -0.53%     
==========================================
  Files         166      167       +1     
  Lines        7679     7750      +71     
  Branches      918      918              
==========================================
  Hits         4441     4441              
- Misses       2971     3042      +71     
  Partials      267      267              
Flag Coverage Δ
uitests 58.17% <ø> (ø)
unittests 54.91% <ø> (-1.96%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
web/src/components/filters/filters-chips.tsx 50.00% <ø> (ø)

... and 1 file with indirect coverage changes

@openshift-merge-robot openshift-merge-robot merged commit eafaa3b into netobserv:main Aug 21, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants