Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1241 Followup - Back and forth show the opposite #372

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

jpinsonneau
Copy link
Contributor

Followup on #369 to update icons

@openshift-ci
Copy link

openshift-ci bot commented Aug 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #372 (ecc4979) into main (f2a289f) will decrease coverage by 0.53%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
- Coverage   57.83%   57.30%   -0.53%     
==========================================
  Files         166      167       +1     
  Lines        7679     7750      +71     
  Branches      918      918              
==========================================
  Hits         4441     4441              
- Misses       2971     3042      +71     
  Partials      267      267              
Flag Coverage Δ
uitests 58.17% <ø> (ø)
unittests 54.91% <ø> (-1.96%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
web/src/components/filters/filters-chips.tsx 50.00% <ø> (ø)

... and 1 file with indirect coverage changes

@openshift-merge-robot openshift-merge-robot merged commit 2b108ab into netobserv:main Aug 22, 2023
8 checks passed
@jpinsonneau jpinsonneau changed the title NETOBSERV-1241 Back and forth show the opposite NETOBSERV-1241 Followup - Back and forth show the opposite Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants