Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1274 index duplicate (improve query perfs) #380

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Sep 7, 2023

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.57% ⚠️

Comparison is base (967e4c8) 57.60% compared to head (c6f748b) 57.03%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #380      +/-   ##
==========================================
- Coverage   57.60%   57.03%   -0.57%     
==========================================
  Files         166      167       +1     
  Lines        7807     7888      +81     
  Branches      958      961       +3     
==========================================
+ Hits         4497     4499       +2     
- Misses       3032     3108      +76     
- Partials      278      281       +3     
Flag Coverage Δ
uitests 57.97% <60.00%> (-0.02%) ⬇️
unittests 54.43% <72.72%> (-2.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
web/src/api/ipfix.ts 100.00% <ø> (ø)
web/src/components/netflow-record/record-panel.tsx 66.29% <0.00%> (ø)
web/src/components/query-summary/summary-panel.tsx 44.77% <25.00%> (ø)
pkg/loki/flow_query.go 65.27% <72.72%> (-0.83%) ⬇️
web/src/components/netflow-record/record-field.tsx 69.56% <100.00%> (ø)
web/src/utils/columns.ts 66.53% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jotak jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Sep 7, 2023
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

New image:
quay.io/netobserv/network-observability-console-plugin:e50845a

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=e50845a make set-plugin-image

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Sep 7, 2023
@jotak
Copy link
Member Author

jotak commented Sep 8, 2023

thanks @jpinsonneau !
/approve

@openshift-ci openshift-ci bot added the approved label Sep 8, 2023
@jotak jotak added no-qe This PR doesn't necessitate QE approval no-doc This PR doesn't require documentation change on the NetObserv operator and removed approved labels Sep 8, 2023
@jotak jotak removed the no-qe This PR doesn't necessitate QE approval label Sep 13, 2023
@jotak
Copy link
Member Author

jotak commented Sep 27, 2023

/approve

@jotak jotak added no-qe This PR doesn't necessitate QE approval and removed approved labels Sep 27, 2023
@jotak
Copy link
Member Author

jotak commented Sep 27, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak jotak merged commit 2804fd2 into netobserv:main Sep 27, 2023
14 checks passed
@jpinsonneau jpinsonneau added the breaking-change This pull request has breaking changes. They should be described in PR description. label Sep 27, 2023
@jpinsonneau
Copy link
Contributor

I'm flagging this PR as breaking-change here since it will display empty result if you update operator without these changes. The opposite should show an error since Duplicate was not a label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved breaking-change This pull request has breaking changes. They should be described in PR description. lgtm no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants