Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1466 NodeDirections / IfDirections #482

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Feb 20, 2024

Description

  • Rename FlowDirection to NodeDirection and improved descriptions
  • Update fields / queries to plural
  • Restore deduping running parallel queries for metrics
  • Only show related fields when necessary in side panel
  • Keep the ability to show columns separately

image

image

image

image

image

Dependencies

netobserv/network-observability-operator#578

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: Patch coverage is 40.74074% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 57.38%. Comparing base (50ea5cc) to head (a3db9c2).

Files Patch % Lines
web/src/components/netflow-record/record-field.tsx 20.00% 8 Missing ⚠️
web/src/components/netflow-record/record-panel.tsx 20.00% 8 Missing ⚠️
pkg/loki/filter.go 22.22% 7 Missing ⚠️
web/src/utils/filter-options.ts 22.22% 7 Missing ⚠️
pkg/model/fields/fields.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #482      +/-   ##
==========================================
- Coverage   57.45%   57.38%   -0.07%     
==========================================
  Files         167      167              
  Lines        8710     8727      +17     
  Branches     1126     1128       +2     
==========================================
+ Hits         5004     5008       +4     
- Misses       3382     3397      +15     
+ Partials      324      322       -2     
Flag Coverage Δ
uitests 58.17% <34.28%> (-0.12%) ⬇️
unittests 55.11% <52.63%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpinsonneau jpinsonneau added the breaking-change This pull request has breaking changes. They should be described in PR description. label Feb 21, 2024
@jpinsonneau jpinsonneau changed the title NETOBSERV-1466 NodeDirection / IfDirection NETOBSERV-1466 NodeDirections / IfDirections Feb 21, 2024
@jpinsonneau jpinsonneau marked this pull request as ready for review February 21, 2024 12:32
jotak
jotak previously approved these changes Mar 1, 2024
Copy link

openshift-ci bot commented Mar 12, 2024

New changes are detected. LGTM label has been removed.

@jpinsonneau
Copy link
Contributor Author

rebased without changes

Copy link

openshift-ci bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Mar 12, 2024

New changes are detected. LGTM label has been removed.

@openshift-merge-bot openshift-merge-bot bot merged commit cb795ce into netobserv:main Mar 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved breaking-change This pull request has breaking changes. They should be described in PR description. lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants