NETOBSERV-1466 NodeDirection / IfDirection

[jpinsonneau]

Description

• Rename FlowDirection to NodeDirection, improved descriptions and restore FlowDirection label when using deduper merge
• Skip reinterpret field renaming since it's now done directly in eBPF
• Update console plugin fields / queries to plural

To setup deduper merge, simply add the following config in ebpf debug (or advanced) configuration:

      advanced:
        env:
          DEDUPER_JUST_MARK: "false"
          DEDUPER_MERGE: "true"

Dependencies

netobserv/netobserv-ebpf-agent#275
netobserv/flowlogs-pipeline#601
netobserv/network-observability-console-plugin#482

Followup

A followup to remove Duplicate field is available at: #580

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.41%. Comparing base (f4d840b) to head (840ba66).

❗ Current head 840ba66 differs from pull request most recent head 20fa2c7. Consider uploading reports for the commit 20fa2c7 to get more accurate results

Files	Patch %	Lines
controllers/flp/flp_pipeline_builder.go	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #578      +/-   ##
==========================================
- Coverage   67.56%   67.41%   -0.15%     
==========================================
  Files          69       69              
  Lines        8192     8182      -10     
==========================================
- Hits         5535     5516      -19     
- Misses       2317     2324       +7     
- Partials      340      342       +2     

Flag	Coverage Δ
unittests	67.41% <80.00%> (-0.15%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jpinsonneau]

@jotak as discussed in last scrum, I have restored FlowDirection as label name to avoid migration.

[jotak]

shouldn't we call the filter "nodeDirection" ? And btw, other filters are in snake case so I guess it's flow_direction or node_direction

[jpinsonneau]

Sure, done in 553bfe2

[jotak]

just a small comment other than that lgtm!

[jpinsonneau]

/retest

[openshift-ci]

@jpinsonneau: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-operator	553bfe2	link	false	/test e2e-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jotak]

/lgtm

[openshift-ci]

New changes are detected. LGTM label has been removed.

[jpinsonneau]

Rebased without changes

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

New changes are detected. LGTM label has been removed.

[openshift-ci]

New changes are detected. LGTM label has been removed.