-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1466 NodeDirection / IfDirection #578
Conversation
Skipping CI for Draft Pull Request. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #578 +/- ##
==========================================
- Coverage 67.56% 67.41% -0.15%
==========================================
Files 69 69
Lines 8192 8182 -10
==========================================
- Hits 5535 5516 -19
- Misses 2317 2324 +7
- Partials 340 342 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f047f8b
to
4601245
Compare
@jotak as discussed in last scrum, I have restored |
field: FlowDirection | ||
filter: direction | ||
filter: flowDirection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we call the filter "nodeDirection" ? And btw, other filters are in snake case so I guess it's flow_direction or node_direction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, done in 553bfe2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a small comment other than that lgtm!
/retest |
@jpinsonneau: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
New changes are detected. LGTM label has been removed. |
Rebased without changes |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
New changes are detected. LGTM label has been removed. |
Description
Renameimproved descriptions and restoreFlowDirection
toNodeDirection
,FlowDirection
label when using deduper mergeTo setup deduper merge, simply add the following config in ebpf debug (or advanced) configuration:
Dependencies
netobserv/netobserv-ebpf-agent#275
netobserv/flowlogs-pipeline#601
netobserv/network-observability-console-plugin#482
Followup
A followup to remove Duplicate field is available at: #580
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.