Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1649: remove obsolete comment #540

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

jotak
Copy link
Member

@jotak jotak commented Jun 11, 2024

Note, there's just nothing to do on the console plugin side, this is all managed in netobserv/network-observability-operator#676

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jun 11, 2024

@jotak: This pull request references NETOBSERV-1649 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Note, there's just nothing to do on the console plugin side, this is all managed in netobserv/network-observability-operator#676

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.56%. Comparing base (d53b334) to head (701343c).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #540      +/-   ##
==========================================
- Coverage   56.71%   56.56%   -0.15%     
==========================================
  Files         174      173       -1     
  Lines        8990     9042      +52     
  Branches     1179     1183       +4     
==========================================
+ Hits         5099     5115      +16     
- Misses       3528     3561      +33     
- Partials      363      366       +3     
Flag Coverage Δ
uitests 57.95% <ø> (+0.10%) ⬆️
unittests 52.64% <ø> (-0.81%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/handler/topology.go 50.54% <ø> (ø)

... and 15 files with indirect coverage changes

@jotak
Copy link
Member Author

jotak commented Jun 21, 2024

/approve

Copy link

openshift-ci bot commented Jun 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b68515b into netobserv:main Jun 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants