-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1649: add drop cause & state labels to metrics #676
Conversation
@jotak: This pull request references NETOBSERV-1649 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@jotak: This pull request references NETOBSERV-1649 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/ok-to-test |
New images:
They will expire after two weeks. To deploy this build: # Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:9c1a198 make deploy
# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-9c1a198 Or as a Catalog Source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-9c1a198
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jotak I could see drops reasons, however some filter options in UI needs to be disabled for packetdrop such as for state and drops since they're not part of the labels when only prom. is used:
![Screenshot 2024-06-20 at 4 50 37 PM](https://private-user-images.githubusercontent.com/87338854/341565491-dc516ea1-51f3-458e-8e88-ad549e985061.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ1MDMxNzcsIm5iZiI6MTcyNDUwMjg3NywicGF0aCI6Ii84NzMzODg1NC8zNDE1NjU0OTEtZGM1MTZlYTEtNTFmMy00NThlLThlODgtYWQ1NDllOTg1MDYxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI0VDEyMzQzN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTdhZjVhOWZlN2YxMGQ0MmUyZWIwMDhlMTQ2OThlOTRkNzhlNDNlZDMxNTM2MTc4ZDI1NTZkYmJjOWQxMDI5MGUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.WEsT-2dwgxBfSanJxloWRSZrVYW488IwHMcDQko8MNY)
@memodi : actually, these filters are available on purpose, because they can be used in some queries. But it doesn't always work, because what matters is the combination of labels. For instance, you can filter on Node individually, you can filter on Namespace individually, but you cannot filter on Node and Namespace. It's the same reason why, in the topology view, if you have a filter on namespaces and then switch to the Node aggregation, you will get an error telling you to enable Loki blah blah. This is similar with your example with drops here, the filter alone is supported, but not in combination with other filters. I can suggest 2 things:
|
this looks good, tested along with PR: netobserv/network-observability-console-plugin/pull/549. Thanks @jotak /label qe-approved |
@jotak: This pull request references NETOBSERV-1649 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Add more metrics info to make prometheus datasource suiting for replacing loki datasource in overview page
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.