-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1649: Improve UX and cases managed with prometheus #549
Conversation
@jotak: This pull request references NETOBSERV-1649 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jotak: This pull request references NETOBSERV-1649 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@jotak: This pull request references NETOBSERV-1649 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #549 +/- ##
==========================================
- Coverage 56.21% 56.10% -0.12%
==========================================
Files 183 183
Lines 9081 9098 +17
Branches 1183 1185 +2
==========================================
- Hits 5105 5104 -1
- Misses 3605 3623 +18
Partials 371 371
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=f8c7c2a make set-plugin-image |
(rebased) |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=3d32371 make set-plugin-image |
@jotak - with this PR it looks good overall, can you clarify what do you mean when you say?
is it to say we'll display dropped bytes/packets on topology edges when there's a match drop cause/state filter? no topology view since drop state didn't match probably?: |
Yes ... and while saying this, I realize this is probably not correct, at least not in every case.. Argh! Need to think more about that.
I guess yes. A way to confirm this is to install loki and switch between forced Loki / Prom datasources |
@memodi I think I'll open another bug for the issue spotted. It sounds tricky to fix. But I wouldn't want to block this PR for that, because it makes an improvement overall |
SGTM. thanks! I'll add comment for NETOBSERV-1740 |
@jotak: This pull request references NETOBSERV-1649 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Automatically switch to PktDropBytes/Packets metrics when there's a drop cause/state filter - Make topology queries less strict on fetching drops for decoration: an error will not break the whole thing anymore - Display warning when that happens - small refactoring related to warning message and details
New changes are detected. LGTM label has been removed. |
(rebased) |
thanks @jpinsonneau .. sorry for the conflicts 😨 |
…rv#549) * NETOBSERV-1649: Improve UX and cases managed with prometheus - Automatically switch to PktDropBytes/Packets metrics when there's a drop cause/state filter - Make topology queries less strict on fetching drops for decoration: an error will not break the whole thing anymore - Display warning when that happens - small refactoring related to warning message and details * Fix error reporting on missing labels * fix lint
* NETOBSERV-1649: Improve UX and cases managed with prometheus - Automatically switch to PktDropBytes/Packets metrics when there's a drop cause/state filter - Make topology queries less strict on fetching drops for decoration: an error will not break the whole thing anymore - Display warning when that happens - small refactoring related to warning message and details * Fix error reporting on missing labels * fix lint
Description
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.