Skip to content

Commit

Permalink
Merge pull request #327 from jotak/restore-metrics
Browse files Browse the repository at this point in the history
NETOBSERV-993 Restore default metrics
  • Loading branch information
jpinsonneau authored Apr 27, 2023
2 parents 949256f + 10aa671 commit ed2d9ab
Show file tree
Hide file tree
Showing 8 changed files with 12 additions and 20 deletions.
2 changes: 1 addition & 1 deletion api/v1alpha1/flowcollector_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ type FLPMetrics struct {

// ignoreTags is a list of tags to specify which metrics to ignore. Each metric is associated with a list of tags. More details in https://github.com/netobserv/network-observability-operator/tree/main/controllers/flowlogspipeline/metrics_definitions .
// Available tags are: egress, ingress, flows, bytes, packets, namespaces, nodes, workloads
//+kubebuilder:default:={"flows","bytes","packets"}
//+kubebuilder:default:={"egress","packets"}
IgnoreTags []string `json:"ignoreTags,omitempty"`
}

Expand Down
2 changes: 1 addition & 1 deletion api/v1beta1/flowcollector_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ type FLPMetrics struct {

// ignoreTags is a list of tags to specify which metrics to ignore. Each metric is associated with a list of tags. More details in https://github.com/netobserv/network-observability-operator/tree/main/controllers/flowlogspipeline/metrics_definitions .
// Available tags are: egress, ingress, flows, bytes, packets, namespaces, nodes, workloads
//+kubebuilder:default:={"flows","bytes","packets"}
//+kubebuilder:default:={"egress","packets"}
IgnoreTags []string `json:"ignoreTags,omitempty"`

// disableAlerts is a list of alerts that should be disabled.
Expand Down
6 changes: 2 additions & 4 deletions bundle/manifests/flows.netobserv.io_flowcollectors.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1951,8 +1951,7 @@ spec:
properties:
ignoreTags:
default:
- flows
- bytes
- egress
- packets
description: 'ignoreTags is a list of tags to specify which
metrics to ignore. Each metric is associated with a list
Expand Down Expand Up @@ -4184,8 +4183,7 @@ spec:
type: array
ignoreTags:
default:
- flows
- bytes
- egress
- packets
description: 'ignoreTags is a list of tags to specify which
metrics to ignore. Each metric is associated with a list
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,7 @@ metadata:
"logLevel": "info",
"metrics": {
"ignoreTags": [
"flows",
"bytes",
"egress",
"packets"
],
"server": {
Expand Down Expand Up @@ -323,8 +322,7 @@ metadata:
"metrics": {
"disableAlerts": [],
"ignoreTags": [
"flows",
"bytes",
"egress",
"packets"
],
"server": {
Expand Down
6 changes: 2 additions & 4 deletions config/crd/bases/flows.netobserv.io_flowcollectors.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1938,8 +1938,7 @@ spec:
properties:
ignoreTags:
default:
- flows
- bytes
- egress
- packets
description: 'ignoreTags is a list of tags to specify which
metrics to ignore. Each metric is associated with a list
Expand Down Expand Up @@ -4171,8 +4170,7 @@ spec:
type: array
ignoreTags:
default:
- flows
- bytes
- egress
- packets
description: 'ignoreTags is a list of tags to specify which
metrics to ignore. Each metric is associated with a list
Expand Down
3 changes: 1 addition & 2 deletions config/samples/flows_v1alpha1_flowcollector.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ spec:
server:
port: 9102
ignoreTags:
- flows
- bytes
- egress
- packets
dropUnusedFields: true
resources:
Expand Down
3 changes: 1 addition & 2 deletions config/samples/flows_v1beta1_flowcollector.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ spec:
server:
port: 9102
ignoreTags:
- flows
- bytes
- egress
- packets
disableAlerts: []
dropUnusedFields: true
Expand Down
4 changes: 2 additions & 2 deletions docs/FlowCollector.md
Original file line number Diff line number Diff line change
Expand Up @@ -3499,7 +3499,7 @@ Metrics define the processor configuration regarding metrics
<td>
ignoreTags is a list of tags to specify which metrics to ignore. Each metric is associated with a list of tags. More details in https://github.com/netobserv/network-observability-operator/tree/main/controllers/flowlogspipeline/metrics_definitions . Available tags are: egress, ingress, flows, bytes, packets, namespaces, nodes, workloads<br/>
<br/>
<i>Default</i>: [flows bytes packets]<br/>
<i>Default</i>: [egress packets]<br/>
</td>
<td>false</td>
</tr><tr>
Expand Down Expand Up @@ -7464,7 +7464,7 @@ Metrics define the processor configuration regarding metrics
<td>
ignoreTags is a list of tags to specify which metrics to ignore. Each metric is associated with a list of tags. More details in https://github.com/netobserv/network-observability-operator/tree/main/controllers/flowlogspipeline/metrics_definitions . Available tags are: egress, ingress, flows, bytes, packets, namespaces, nodes, workloads<br/>
<br/>
<i>Default</i>: [flows bytes packets]<br/>
<i>Default</i>: [egress packets]<br/>
</td>
<td>false</td>
</tr><tr>
Expand Down

0 comments on commit ed2d9ab

Please sign in to comment.