Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-993 Restore default metrics #327

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Apr 19, 2023

Re-enabling the defaults, so that the related dashboard is visible by default

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #327 (10aa671) into main (36de463) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #327   +/-   ##
=======================================
  Coverage   50.90%   50.90%           
=======================================
  Files          43       43           
  Lines        5080     5080           
=======================================
  Hits         2586     2586           
  Misses       2293     2293           
  Partials      201      201           
Flag Coverage Δ
unittests 50.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/v1alpha1/flowcollector_types.go 100.00% <ø> (ø)
api/v1beta1/flowcollector_types.go 100.00% <ø> (ø)

Copy link
Contributor

@memodi memodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved based on code inspection
/label qe-approved

@openshift-ci openshift-ci bot added qe-approved QE has approved this pull request lgtm labels Apr 19, 2023
@memodi
Copy link
Contributor

memodi commented Apr 24, 2023

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 24, 2023
@github-actions
Copy link

New images:

  • quay.io/netobserv/network-observability-operator:97a9d81
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-97a9d81
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-97a9d81

They will expire after two weeks.

Catalog source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-97a9d81
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@memodi
Copy link
Contributor

memodi commented Apr 26, 2023

@jpinsonneau @OlivierCazade - this is good to merge from my end, could one of you take a look and merge? TIA

Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link

openshift-ci bot commented Apr 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpinsonneau jpinsonneau merged commit ed2d9ab into netobserv:main Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants