NETOBSERV-433 and NETOBSERV-373 - unify names #164
Conversation
| @@ -72,7 +72,7 @@ func (c *Reconciler) reconcileNamespace(ctx context.Context) error { | |||
| ObjectMeta: metav1.ObjectMeta{ | |||
| Name: c.privilegedNamespace, | |||
| Labels: map[string]string{ | |||
| "app": "network-observability-operator", | |||
| "app": constants.OperatorName, | |||
There was a problem hiding this comment.
Should it be netobserv-operator or netobserv ?
There was a problem hiding this comment.
Actually I never realized the privileged namespace had an app label ... @mariomac do you remember why is that? Is it needed?
There was a problem hiding this comment.
As far as I remember it was just to follow k8s recommendations
We also talked about adding app.kubernetes.io/part-of & app.kubernetes.io/version in the past.
Maybe it's the right time to do it ?
There was a problem hiding this comment.
Yeah as part as I remember it was just for self-documentation metadata. Something like "this namespace belongs to this app", even if it is clear enough in the namespace name.
There was a problem hiding this comment.
ok, to circle back to Julien's first question, as we're talking about "app", netobserv-operator makes more sense I think than netobserv, which isn't an app. That would be different if it was a part-of annotation.
| Expect(k8sClient.Get(ctx, nsKey, &ns)).To(Succeed()) | ||
| Expect(ns.Labels).To(Satisfy(func(labels map[string]string) bool { | ||
| return helper.IsSubSet(ns.Labels, map[string]string{ | ||
| "app": "network-observability-operator", | ||
| "app": constants.OperatorName, |
- Use "netobserv" instead of "network-observability" (e.g. as default namespace)
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
* Add support for barGauge visualization * Add mice-elephants histogram * Add support for heatmap visualization * Update docs/metrics.md Co-authored-by: Eran Raichstein <eranra@il.ibm.com> * Update network_definitions/mice_elephants_histogram.yaml Co-authored-by: Eran Raichstein <eranra@il.ibm.com> * Update network_definitions/mice_elephants_histogram.yaml Co-authored-by: Eran Raichstein <eranra@il.ibm.com> * Rename mice_elephants_histogram.yaml -> flows_length_histogram.yaml * Remove mice_elephants.yaml * Change mice-elephants to flows length * Update buckets * Fix histograms display by setting threshold Co-authored-by: Eran Raichstein <eranra@il.ibm.com>
Other required PRs: