-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1104: remove italic text in CRD doc #407
Conversation
@jotak: This pull request references NETOBSERV-1104 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jotak: This pull request references NETOBSERV-1104 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jotak: This pull request references NETOBSERV-1104 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@skrthomas this is a slight formatting change for the API reference: previously the mentions of "unsupported" or "deprecated" were in italic, which worked well in the generated asciidoc, but that doesn't work well for the doc displayed in the OLM form of the Console ... so removing italic in favor of brackets; does that sound good to you? |
Codecov Report
@@ Coverage Diff @@
## main #407 +/- ##
=======================================
Coverage 55.49% 55.49%
=======================================
Files 45 45
Lines 5874 5874
=======================================
Hits 3260 3260
Misses 2393 2393
Partials 221 221
Flags with carried forward coverage won't be shown. Click here to find out more.
|
New images:
They will expire after two weeks. To deploy this build: # Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:037e152 make deploy
# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-037e152 Or as a Catalog Source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-037e152
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
- Remove mention of INGRESS/EGRESS having to be enabled since it's not configurable - Remove italic text (cf netobserv#407 ) - Update bundle
/label qe-approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* NETOBSERV-1110: Enable support for Flow RTT Signed-off-by: Dushyant Behl <dushyantbehl@users.noreply.github.com> * Convert ebpf operator types to enum instead of boolean. Signed-off-by: Dushyant Behl <dushyantbehl@users.noreply.github.com> * Use enum for agent features Also a couple of fixes: - In connection tracking, field "MaxTimeFlowRttNs" was wrongly bound to DNSTracking feature instead of FlowRTT - Fixed regression on agent's AllowHostDirVolumePlugin SCC for DNS - From a previous merged change mistake, in Agent controller, when drops/dns features were enabled without privileged mode, the corresponding error message wasn't written anymore * Update controllers/flowcollector_controller_iso_test.go Co-authored-by: Joel Takvorian <joel.takvorian@homeblocks.net> * Update api/v1beta1/flowcollector_types.go Co-authored-by: Julien Pinsonneau <91894519+jpinsonneau@users.noreply.github.com> * Doc update - Remove mention of INGRESS/EGRESS having to be enabled since it's not configurable - Remove italic text (cf #407 ) - Update bundle * Address review comments - Use PascalCase for enums - Copy array in webhook - Update bundle * update doc --------- Signed-off-by: Dushyant Behl <dushyantbehl@users.noreply.github.com> Co-authored-by: Joel Takvorian <jtakvori@redhat.com> Co-authored-by: Joel Takvorian <joel.takvorian@homeblocks.net> Co-authored-by: Julien Pinsonneau <91894519+jpinsonneau@users.noreply.github.com>
Description
The CRD doc displayed in the OLM console doesn't support italic text, so remove it from the doc (replaced with brackets)
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.