NETOBSERV-1110: Enable support for Flow RTT #394

dushyantbehl · 2023-07-12T13:47:22Z

Related console PR: netobserv/network-observability-console-plugin#365

openshift-ci-robot · 2023-07-12T13:47:26Z

@dushyantbehl: This pull request references NETOBSERV-1110 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dushyantbehl · 2023-07-12T13:47:39Z

/ok-to-test

github-actions · 2023-07-12T13:52:57Z

New images:

quay.io/netobserv/network-observability-operator:92a3fee
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-92a3fee
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-92a3fee

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:92a3fee make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-92a3fee

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-92a3fee
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

codecov · 2023-07-12T13:53:19Z

Codecov Report

Patch coverage: 17.39% and project coverage change: +0.32% 🎉

Comparison is base (3e5454d) 55.49% compared to head (925fc34) 55.82%.
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #394      +/-   ##
==========================================
+ Coverage   55.49%   55.82%   +0.32%     
==========================================
  Files          45       45              
  Lines        5874     5888      +14     
==========================================
+ Hits         3260     3287      +27     
+ Misses       2393     2380      -13     
  Partials      221      221

Flag	Coverage Δ
unittests	`55.82% <17.39%> (+0.32%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
api/v1alpha1/flowcollector_webhook.go	`0.00% <0.00%> (ø)`
api/v1alpha1/zz_generated.conversion.go	`0.25% <ø> (ø)`
api/v1beta1/flowcollector_types.go	`100.00% <ø> (ø)`
api/v1beta1/zz_generated.deepcopy.go	`53.79% <0.00%> (-1.57%)`	⬇️
controllers/consoleplugin/consoleplugin_objects.go	`94.61% <0.00%> (-0.82%)`	⬇️
controllers/ebpf/agent_controller.go	`69.59% <0.00%> (-1.11%)`	⬇️
...ntrollers/ebpf/internal/permissions/permissions.go	`45.50% <0.00%> (+1.32%)`	⬆️
controllers/flowlogspipeline/flp_common_objects.go	`80.88% <0.00%> (-0.80%)`	⬇️
pkg/helper/flowcollector.go	`65.97% <57.14%> (-0.69%)`	⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

api/v1alpha1/flowcollector_types.go

controllers/ebpf/agent_controller.go

controllers/flowlogspipeline/flp_common_objects.go

github-actions · 2023-07-13T10:12:14Z

New images:

quay.io/netobserv/network-observability-operator:e44e1b3
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-e44e1b3
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-e44e1b3

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:e44e1b3 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-e44e1b3

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-e44e1b3
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

jpinsonneau · 2023-07-28T12:11:54Z

As discussed, the RTT is not present in every flow and the enrichment ratio depends of sampling.

We can retreive the ratio of flows containing TimeFlowRttNs using the following query:

http://localhost:3100/loki/api/v1/query_range?query=count by(app) (count_over_time({app="netobserv-flowcollector",_RecordType="flowLog"}|~`"TimeFlowRttNs`[5m]))/count by(app) (count_over_time({app="netobserv-flowcollector",_RecordType="flowLog"}[5m]))*100&step=5m

Sampling	flows with RTT
1	45 %
25	10 %
50	5 %
100	< 1 %

We should document that 📜

jpinsonneau · 2023-08-01T13:05:21Z

@dushyantbehl can you please rebase your PR ?
After that we'll need to list flowRTT in console plugin configMap features section to be able to detect when it's enabled.

https://github.com/netobserv/network-observability-operator/blob/main/controllers/consoleplugin/consoleplugin_objects.go#L353-L359

dushyantbehl · 2023-08-02T08:20:58Z

/ok-to-test

github-actions · 2023-08-02T08:26:08Z

New images:

quay.io/netobserv/network-observability-operator:251705a
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-251705a
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-251705a

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:251705a make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-251705a

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-251705a
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

msherif1234 · 2023-08-24T15:25:02Z

controllers/ebpf/internal/permissions/permissions.go

 		scc.AllowHostDirVolumePlugin = true
 	}
-	if (desired.EnablePktDrop != nil && !*desired.EnablePktDrop) &&


This was added to handle special case where u start with both features on then u just disable one since we don't compare current vs desired we could endup clearing the AllowHostDirVolumePlugin there was an issue about this by @memodi

https://issues.redhat.com/browse/NETOBSERV-1191 this one?

@msherif1234 scc is created a few lines above with AllowHostDirVolumePlugin not initialized , and since it's a bool , it means it's false already . So I don't see the point of setting it to false here?

@msherif1234 if you're talking about the nil-check, it's not relevant anymore now, as the new Features is a slice, unlike the previous EnablePktDrop / EnableDNSTracking that were bool pointers

can u try the steps mentioned in the bug shared above to be sure, the reason I added the explicit false to make scc desired different than actual anyway I kind of forget the details its been awhile just make sure the steps showing in the above issue are fine

Just tried to reproduce that old ticket, and it works fine: I get no error on the daemonset, pods are updated as expected, flows are flowing with dns/drops info

msherif1234 · 2023-08-24T20:19:05Z

api/v1beta1/flowcollector_types.go

+// Agent feature, can be one of:<br>
+// - `PKT_DROP`, to track packet drops.<br>
+// - `DNS_TRACKING`, to track specific information on DNS traffic.<br>
+// - `FLOW_RTT`, to track L4 latency. <i>Unsupported (*)</i><br>


pls remove
and other weired chars at the end of the above lines and every else in this file

@msherif1234 I guess you are talking about the HTML blocks right ? That's not new to this PR: https://issues.redhat.com/browse/NETOBSERV-1104 ; it's related to asciidocs
Let's keep this as is and solve it in the related ticket

msherif1234 · 2023-08-24T20:24:48Z

api/v1beta1/flowcollector_types.go

+	// If the `spec.agent.eBPF.privileged` parameter is not set, an error is reported.<br>
+	// - `FLOW_RTT` <i>Unsupported (*)</i>: allows enabling flow latency (RTT) calculations in the eBPF agent during TCP handshakes.
+	// This feature needs both INGRESS and EGRESS direction flow capture and will be disabled if they are not both enabled.<br>
+	// +optional


should we add or we need to allow Features: block with no features ?

// +kubebuilder:validation:Required // +kubebuilder:validation:MinItems:=1

I don't think we need that check. We could simply initialize it empty []

yeah I don't even think an empty array initialization is needed, we don't do that in other places (e.g. exporters list)

msherif1234 · 2023-08-24T20:31:09Z

api/v1alpha1/flowcollector_webhook.go

@@ -64,12 +64,12 @@ func (r *FlowCollector) ConvertTo(dstRaw conversion.Hub) error {

 	dst.Spec.Loki.Enable = restored.Spec.Loki.Enable

-	dst.Spec.Agent.EBPF.PktDrop = restored.Spec.Agent.EBPF.PktDrop
-	dst.Spec.Agent.EBPF.DNSTracking = restored.Spec.Agent.EBPF.DNSTracking
+	if restored.Spec.Agent.EBPF.Features != nil {


This is a slice u need to allocate the space then copy content

dst.Spec.Agent.EBPF.Features = make([]AgentFeature, len(restored.Spec.Agent.EBPF.Features)) copy(dst.Spec.Agent.EBPF.Features, restored.Spec.Agent.EBPF.Features)

msherif1234 · 2023-08-24T22:17:13Z

api/v1beta1/flowcollector_types.go

-	ConfigDisabled FeatureConfigType = "DISABLED"
+	PktDrop     AgentFeature = "PKT_DROP"
+	DNSTracking AgentFeature = "DNS_TRACKING"
+	FlowRTT     AgentFeature = "FLOW_RTT"


if I am not mistaken Strings need to use Pascal not snake case ?

PktDrop AgentFeature = "PacketsDrop" DNSTracking AgentFeature = "DnsTacking" FlowRTT AgentFeature = "FlowRtt"

You're right, idk why I had in mind the best practice was upper case

api/v1beta1/flowcollector_types.go

Co-authored-by: Julien Pinsonneau <91894519+jpinsonneau@users.noreply.github.com>

github-actions · 2023-08-29T08:25:28Z

New images:

quay.io/netobserv/network-observability-operator:e7c6868
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-e7c6868
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-e7c6868

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:e7c6868 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-e7c6868

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-e7c6868
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

- Remove mention of INGRESS/EGRESS having to be enabled since it's not configurable - Remove italic text (cf netobserv#407 ) - Update bundle

- Use PascalCase for enums - Copy array in webhook - Update bundle

jotak · 2023-08-29T09:09:27Z

@dushyantbehl @msherif1234 @jpinsonneau : I updated the PR to address feedback

github-actions · 2023-08-29T09:24:13Z

New images:

quay.io/netobserv/network-observability-operator:28a41df
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-28a41df
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-28a41df

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:28a41df make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-28a41df

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-28a41df
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

msherif1234 · 2023-08-29T16:41:13Z

/lgtm

jotak · 2023-09-05T11:51:29Z

/approve

openshift-ci · 2023-09-05T11:51:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jotak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dushyantbehl added enhancement New feature or request breaking-change This pull request has breaking changes. They should be described in PR description. labels Jul 12, 2023

dushyantbehl requested review from jotak and jpinsonneau July 12, 2023 13:47

openshift-ci-robot added the jira/valid-reference label Jul 12, 2023

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 12, 2023

jpinsonneau reviewed Jul 13, 2023

View reviewed changes

api/v1alpha1/flowcollector_types.go Outdated Show resolved Hide resolved

jpinsonneau reviewed Jul 13, 2023

View reviewed changes

controllers/ebpf/agent_controller.go Show resolved Hide resolved

jpinsonneau reviewed Jul 13, 2023

View reviewed changes

controllers/flowlogspipeline/flp_common_objects.go Outdated Show resolved Hide resolved

dushyantbehl force-pushed the main branch from 2ab3a64 to f0b482d Compare July 13, 2023 09:58

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 13, 2023

jpinsonneau added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 13, 2023

openshift-merge-robot added the needs-rebase label Jul 13, 2023

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 13, 2023

dushyantbehl force-pushed the main branch from 9960f9e to 927b6b5 Compare August 2, 2023 08:18

openshift-merge-robot removed the needs-rebase label Aug 2, 2023

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Aug 2, 2023

openshift-merge-robot added the needs-rebase label Aug 10, 2023

dushyantbehl force-pushed the main branch from 927b6b5 to 6a5ce4c Compare August 24, 2023 05:39

openshift-merge-robot removed the needs-rebase label Aug 24, 2023

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Aug 24, 2023

openshift-ci bot assigned jpinsonneau Aug 24, 2023

msherif1234 reviewed Aug 24, 2023

View reviewed changes

jpinsonneau reviewed Aug 25, 2023

View reviewed changes

api/v1beta1/flowcollector_types.go Outdated Show resolved Hide resolved

jotak dismissed jpinsonneau’s stale review via 369d3aa August 29, 2023 07:22

Update api/v1beta1/flowcollector_types.go

369d3aa

Co-authored-by: Julien Pinsonneau <91894519+jpinsonneau@users.noreply.github.com>

openshift-ci bot removed the lgtm label Aug 29, 2023

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Aug 29, 2023

jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Aug 29, 2023

Doc update

63bd6ae

- Remove mention of INGRESS/EGRESS having to be enabled since it's not configurable - Remove italic text (cf netobserv#407 ) - Update bundle

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Aug 29, 2023

Address review comments

a720653

- Use PascalCase for enums - Copy array in webhook - Update bundle

update doc

925fc34

jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Aug 29, 2023

jpinsonneau mentioned this pull request Aug 29, 2023

NETOBSERV-1231 RTT metrics #408

Closed

10 tasks

openshift-ci bot assigned msherif1234 Aug 29, 2023

openshift-ci bot added the lgtm label Aug 29, 2023

openshift-ci bot added the approved label Sep 5, 2023

openshift-merge-robot merged commit 51294b8 into netobserv:main Sep 5, 2023
9 checks passed

msherif1234 mentioned this pull request Sep 7, 2023

fix DNStracking and packet drop features name in the API #410

Merged

10 tasks

jotak mentioned this pull request Oct 24, 2023

NETOBSERV-764: Loki v1beta2 model follow-up #474

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NETOBSERV-1110: Enable support for Flow RTT #394

NETOBSERV-1110: Enable support for Flow RTT #394

dushyantbehl commented Jul 12, 2023 •

edited by jotak

Loading

openshift-ci-robot commented Jul 12, 2023 •

edited by openshift-ci bot

Loading

dushyantbehl commented Jul 12, 2023

github-actions bot commented Jul 12, 2023

codecov bot commented Jul 12, 2023 •

edited

Loading

github-actions bot commented Jul 13, 2023

jpinsonneau commented Jul 28, 2023

jpinsonneau commented Aug 1, 2023

dushyantbehl commented Aug 2, 2023

github-actions bot commented Aug 2, 2023

msherif1234 Aug 24, 2023

memodi Aug 24, 2023

jotak Aug 24, 2023

jotak Aug 24, 2023

msherif1234 Aug 24, 2023

jotak Aug 29, 2023

msherif1234 Aug 24, 2023 •

edited

Loading

jpinsonneau Aug 25, 2023

msherif1234 Aug 24, 2023 •

edited

Loading

jpinsonneau Aug 25, 2023

jotak Aug 29, 2023

msherif1234 Aug 24, 2023

jotak Aug 29, 2023

msherif1234 Aug 24, 2023 •

edited

Loading

jotak Aug 29, 2023

jotak Aug 29, 2023

github-actions bot commented Aug 29, 2023

jotak commented Aug 29, 2023

github-actions bot commented Aug 29, 2023

msherif1234 commented Aug 29, 2023

jotak commented Sep 5, 2023

openshift-ci bot commented Sep 5, 2023

NETOBSERV-1110: Enable support for Flow RTT #394

NETOBSERV-1110: Enable support for Flow RTT #394

Conversation

dushyantbehl commented Jul 12, 2023 • edited by jotak Loading

openshift-ci-robot commented Jul 12, 2023 • edited by openshift-ci bot Loading

dushyantbehl commented Jul 12, 2023

github-actions bot commented Jul 12, 2023

codecov bot commented Jul 12, 2023 • edited Loading

Codecov Report

github-actions bot commented Jul 13, 2023

jpinsonneau commented Jul 28, 2023

jpinsonneau commented Aug 1, 2023

dushyantbehl commented Aug 2, 2023

github-actions bot commented Aug 2, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

msherif1234 Aug 24, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

msherif1234 Aug 24, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

msherif1234 Aug 24, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Aug 29, 2023

jotak commented Aug 29, 2023

github-actions bot commented Aug 29, 2023

msherif1234 commented Aug 29, 2023

jotak commented Sep 5, 2023

openshift-ci bot commented Sep 5, 2023

dushyantbehl commented Jul 12, 2023 •

edited by jotak

Loading

openshift-ci-robot commented Jul 12, 2023 •

edited by openshift-ci bot

Loading

codecov bot commented Jul 12, 2023 •

edited

Loading

msherif1234 Aug 24, 2023 •

edited

Loading

msherif1234 Aug 24, 2023 •

edited

Loading

msherif1234 Aug 24, 2023 •

edited

Loading