NETOBSERV-1342: new FlowMetric API (dev preview) #508

jotak · 2023-12-06T16:54:13Z

Description

operator-sdk code scaffolding to create a new API called FlowMetrics
initial implementation of the api type
remove v1alpha1 deprecation since this is also a v1alpha1 sharing same
package
shrinking the deprecated flowcollector v1alpha1 alm sample to simplify
CSV
since v1alpha1 is imported in business code again, there was an
import cycle with helper package=> to fix it, moving some code out of
"helper"
Implement converting new API to FLP config
Provide some examples
Create watch
Add tests

Follow-ups:

Improve FLP API to add more filtering capabilities: e.g: to filter for cross-something traffic (cross-namespaces, cross-AZ) we'd need a specific matcher => NETOBSERV-1425
Improve IP categorization to more accurately detect what is external or not (e.g. seeing some local loop IPs being detected as external with the current hacks) => NETOBSERV-1426

Dependencies

Based on #510

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

openshift-ci-robot · 2023-12-06T16:54:17Z

@jotak: This pull request references NETOBSERV-1342 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Description

operator-sdk code scaffolding to create a new API called FlowMetrics

initial implementation of the api type

remove v1alpha1 deprecation since this is also a v1alpha1 sharing same
package

shrinking the deprecated flowcollector v1alpha1 alm sample to simplify
CSV

since v1alpha1 is imported in business code again, there was an
import cycle with helper package=> to fix it, moving some code out of
"helper"

Implement converting new API to FLP config

Provide some examples

TODO:

Create watch

Add tests

Later:

Improve FLP API to add more filtering capabilities: e.g: to filter for cross-something traffic (cross-namespaces, cross-AZ) we'd need a specific matcher

Improve IP categorization to more accurately detect what is external or not (e.g. seeing some local loop IPs being detected as external with the current hacks)

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).

Does this PR require product documentation?

If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.

Does this PR require a product release notes entry?

If so, fill in "Release Note Text" in the JIRA.

Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.

If so, make sure it is described in the JIRA ticket.

QE requirements (check 1 from the list):

Standard QE validation, with pre-merge tests unless stated otherwise.

Regression tests only (e.g. refactoring with no user-facing change).

No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-12-06T16:54:23Z

@jotak: This pull request references NETOBSERV-1342 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Description

operator-sdk code scaffolding to create a new API called FlowMetrics

initial implementation of the api type

remove v1alpha1 deprecation since this is also a v1alpha1 sharing same
package

shrinking the deprecated flowcollector v1alpha1 alm sample to simplify
CSV

since v1alpha1 is imported in business code again, there was an
import cycle with helper package=> to fix it, moving some code out of
"helper"

Implement converting new API to FLP config

Provide some examples

TODO:

Create watch

Add tests

Later:

Improve FLP API to add more filtering capabilities: e.g: to filter for cross-something traffic (cross-namespaces, cross-AZ) we'd need a specific matcher

Improve IP categorization to more accurately detect what is external or not (e.g. seeing some local loop IPs being detected as external with the current hacks)

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).

Does this PR require product documentation?

If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.

Does this PR require a product release notes entry?

If so, fill in "Release Note Text" in the JIRA.

Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.

If so, make sure it is described in the JIRA ticket.

QE requirements (check 1 from the list):

Standard QE validation, with pre-merge tests unless stated otherwise.

Regression tests only (e.g. refactoring with no user-facing change).

No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-12-06T16:54:27Z

@jotak: This pull request references NETOBSERV-1342 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Description

operator-sdk code scaffolding to create a new API called FlowMetrics

initial implementation of the api type

remove v1alpha1 deprecation since this is also a v1alpha1 sharing same
package

shrinking the deprecated flowcollector v1alpha1 alm sample to simplify
CSV

since v1alpha1 is imported in business code again, there was an
import cycle with helper package=> to fix it, moving some code out of
"helper"

Implement converting new API to FLP config

Provide some examples

TODO:

Create watch

Add tests

Later:

Improve FLP API to add more filtering capabilities: e.g: to filter for cross-something traffic (cross-namespaces, cross-AZ) we'd need a specific matcher

Improve IP categorization to more accurately detect what is external or not (e.g. seeing some local loop IPs being detected as external with the current hacks)

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).

Does this PR require product documentation?

If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.

Does this PR require a product release notes entry?

If so, fill in "Release Note Text" in the JIRA.

Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.

If so, make sure it is described in the JIRA ticket.

QE requirements (check 1 from the list):

Standard QE validation, with pre-merge tests unless stated otherwise.

Regression tests only (e.g. refactoring with no user-facing change).

No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jotak · 2023-12-06T16:57:04Z

Here's an example that creates a metric to track pods talking with cluster-external IPs (or supposed to be ... not 100% accurate) :

apiVersion: flows.netobserv.io/v1alpha1
kind: FlowMetric
metadata:
  name: flowmetric-pods-talking-outside
spec:
  metricName: pods_talking_outside
  type: Counter
  valueField: Bytes
  labels: [SrcK8S_Name,SrcK8S_Namespace,SrcK8S_OwnerName,SrcK8S_OwnerType,DstAddr]
  filters:
  - field: DstK8S_OwnerType
    matchType: Absence
  - field: SrcK8S_Type
    value: Pod
  - field: Duplicate
    value: "false"
  - field: FlowDirection
    value: "1|2"
    matchType: Regex

openshift-ci-robot · 2023-12-07T10:30:24Z

@jotak: This pull request references NETOBSERV-1342 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Description

operator-sdk code scaffolding to create a new API called FlowMetrics

initial implementation of the api type

remove v1alpha1 deprecation since this is also a v1alpha1 sharing same
package

shrinking the deprecated flowcollector v1alpha1 alm sample to simplify
CSV

since v1alpha1 is imported in business code again, there was an
import cycle with helper package=> to fix it, moving some code out of
"helper"

Implement converting new API to FLP config

Provide some examples

TODO:

Create watch

Add tests

Follow-ups:

Improve FLP API to add more filtering capabilities: e.g: to filter for cross-something traffic (cross-namespaces, cross-AZ) we'd need a specific matcher => NETOBSERV-1425

Improve IP categorization to more accurately detect what is external or not (e.g. seeing some local loop IPs being detected as external with the current hacks) => NETOBSERV-1426

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).

Does this PR require product documentation?

If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.

Does this PR require a product release notes entry?

If so, fill in "Release Note Text" in the JIRA.

Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.

If so, make sure it is described in the JIRA ticket.

QE requirements (check 1 from the list):

Standard QE validation, with pre-merge tests unless stated otherwise.

Regression tests only (e.g. refactoring with no user-facing change).

No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-12-08T09:50:40Z

@jotak: This pull request references NETOBSERV-1342 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Description

operator-sdk code scaffolding to create a new API called FlowMetrics

initial implementation of the api type

remove v1alpha1 deprecation since this is also a v1alpha1 sharing same
package

shrinking the deprecated flowcollector v1alpha1 alm sample to simplify
CSV

since v1alpha1 is imported in business code again, there was an
import cycle with helper package=> to fix it, moving some code out of
"helper"

Implement converting new API to FLP config

Provide some examples

Create watch

Add tests

Follow-ups:

Improve FLP API to add more filtering capabilities: e.g: to filter for cross-something traffic (cross-namespaces, cross-AZ) we'd need a specific matcher => NETOBSERV-1425

Improve IP categorization to more accurately detect what is external or not (e.g. seeing some local loop IPs being detected as external with the current hacks) => NETOBSERV-1426

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).

Does this PR require product documentation?

If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.

Does this PR require a product release notes entry?

If so, fill in "Release Note Text" in the JIRA.

Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.

If so, make sure it is described in the JIRA ticket.

QE requirements (check 1 from the list):

Standard QE validation, with pre-merge tests unless stated otherwise.

Regression tests only (e.g. refactoring with no user-facing change).

No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-12-08T09:54:23Z

@jotak: This pull request references NETOBSERV-1342 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Description

operator-sdk code scaffolding to create a new API called FlowMetrics

initial implementation of the api type

remove v1alpha1 deprecation since this is also a v1alpha1 sharing same
package

shrinking the deprecated flowcollector v1alpha1 alm sample to simplify
CSV

since v1alpha1 is imported in business code again, there was an
import cycle with helper package=> to fix it, moving some code out of
"helper"

Implement converting new API to FLP config

Provide some examples

Create watch

Add tests

Follow-ups:

Improve FLP API to add more filtering capabilities: e.g: to filter for cross-something traffic (cross-namespaces, cross-AZ) we'd need a specific matcher => NETOBSERV-1425

Improve IP categorization to more accurately detect what is external or not (e.g. seeing some local loop IPs being detected as external with the current hacks) => NETOBSERV-1426

Dependencies

Based on #510

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).

Does this PR require product documentation?

If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.

Does this PR require a product release notes entry?

If so, fill in "Release Note Text" in the JIRA.

Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.

If so, make sure it is described in the JIRA ticket.

QE requirements (check 1 from the list):

Standard QE validation, with pre-merge tests unless stated otherwise.

Regression tests only (e.g. refactoring with no user-facing change).

No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov · 2023-12-08T10:08:33Z

Codecov Report

Attention: 67 lines in your changes are missing coverage. Please review.

Comparison is base (b9b2e2f) 66.72% compared to head (2eae453) 56.18%.
Report is 1 commits behind head on main.

Files	Patch %	Lines
apis/flowmetrics/v1alpha1/zz_generated.deepcopy.go	34.14%	48 Missing and 6 partials ⚠️
controllers/flp/flp_pipeline_builder.go	74.28%	6 Missing and 3 partials ⚠️
controllers/flp/flp_controller.go	71.42%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #508       +/-   ##
===========================================
- Coverage   66.72%   56.18%   -10.55%     
===========================================
  Files          63       69        +6     
  Lines        7526     9074     +1548     
===========================================
+ Hits         5022     5098       +76     
- Misses       2185     3647     +1462     
- Partials      319      329       +10

Flag	Coverage Δ
unittests	`56.18% <63.97%> (-10.55%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jpinsonneau · 2023-12-13T15:34:39Z

pkg/test/envtest.go

@@ -25,6 +25,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
 	"sigs.k8s.io/controller-runtime/pkg/metrics/server"

+	flowsv1alpha1 "github.com/netobserv/network-observability-operator/api/v1alpha1"


We could actually decorrelate flowcollector and flowmetric by renaming api folder to apis with a subfolders for each of these. Here is an example with loki operator:
https://github.com/grafana/loki/tree/b18078827ea320bf6d9494f2eef8b315074934c6/operator/apis

Then you can add to scheme independently even if the packages names are the same (v1 in this example):
https://github.com/grafana/loki/blob/b18078827ea320bf6d9494f2eef8b315074934c6/operator/main.go#L41-L43

good idea, done

Thanks ! Would it make sense to keep deprecation on FlowCollector v1alpha1 then ?

yes I actually put it back : https://github.com/netobserv/network-observability-operator/pull/508/files#diff-ed38f87ac78aef4d230ad8674dafbf289f6de5ea1fdfd65685dc391eb07efc21R17

jpinsonneau · 2023-12-13T15:46:22Z

api/v1alpha1/flowmetric_types.go

+type FlowMetricStatus struct {
+	// INSERT ADDITIONAL STATUS FIELD - define observed state of cluster
+	// Important: Run "make" to regenerate code after modifying this file
+}


It would be great to have a validation result here in case something went wrong.
At first maybe just report if flowMetricToFLP returned an error ?

In the future we could improve to check valueField, labels and filters are correct for example.

This looks like something to do in a validation webhook, no?
I am creating a story for it: https://issues.redhat.com/browse/NETOBSERV-1447

OlivierCazade

LGTM

openshift-ci-robot · 2024-01-09T16:13:37Z

@jotak: This pull request references NETOBSERV-1342 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Description

operator-sdk code scaffolding to create a new API called FlowMetrics

initial implementation of the api type

remove v1alpha1 deprecation since this is also a v1alpha1 sharing same
package

shrinking the deprecated flowcollector v1alpha1 alm sample to simplify
CSV

since v1alpha1 is imported in business code again, there was an
import cycle with helper package=> to fix it, moving some code out of
"helper"

Implement converting new API to FLP config

Provide some examples

Create watch

Add tests

Follow-ups:

Improve FLP API to add more filtering capabilities: e.g: to filter for cross-something traffic (cross-namespaces, cross-AZ) we'd need a specific matcher => NETOBSERV-1425

Improve IP categorization to more accurately detect what is external or not (e.g. seeing some local loop IPs being detected as external with the current hacks) => NETOBSERV-1426

Dependencies

Based on #510

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).

Does this PR require product documentation?

If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.

Does this PR require a product release notes entry?

If so, fill in "Release Note Text" in the JIRA.

Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.

If so, make sure it is described in the JIRA ticket.

QE requirements (check 1 from the list):

Standard QE validation, with pre-merge tests unless stated otherwise.

Regression tests only (e.g. refactoring with no user-facing change).

No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

memodi · 2024-01-09T19:38:56Z

/ok-to-test

github-actions · 2024-01-09T19:42:36Z

New images:

quay.io/netobserv/network-observability-operator:602d080
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-602d080
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-602d080

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:602d080 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-602d080

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-602d080
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

memodi · 2024-01-11T19:35:05Z

@jotak - I regression tested this all of the backend tests except upgrade test and all passed:
https://mastern-jenkins-csb-openshift-qe.apps.ocp-c1.prod.psi.redhat.com/job/ocp-common/job/ginkgo-test/223583/console
Also, verified flow based and health dashboards with default metrics

I just have couple of concerns around noting it as dev preview in CRD, I have noted them in slack thread here

- operator-sdk code scaffolding to create a new API called FlowMetrics - initial implementation of the api type - remove v1alpha1 deprecation since this is also a v1alpha1 sharing same package - shrinking the deprecated flowcollector v1alpha1 alm sample to simplify CSV - since v1alpha1 is imported in business code again, there was an import cycle with helper package=> to fix it, moving some code out of "helper" Implement converting new API to FLP config Provide some examples Add watch, add tests, some syntax sugar Ad omitempty

github-actions · 2024-01-12T09:55:45Z

New images:

quay.io/netobserv/network-observability-operator:0b19c17
quay.io/netobserv/network-observability-operator-bundle:v0.0.0-0b19c17
quay.io/netobserv/network-observability-operator-catalog:v0.0.0-0b19c17

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:0b19c17 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-0b19c17

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-0b19c17
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

OlivierCazade · 2024-01-12T13:19:34Z

/lgtm

jotak · 2024-01-12T13:21:43Z

/approve

openshift-ci · 2024-01-12T13:21:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jotak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added the jira/valid-reference label Dec 6, 2023

openshift-ci bot added the do-not-merge/work-in-progress label Dec 6, 2023

jotak force-pushed the metrics-api branch from 03ecd50 to e7c8a14 Compare December 7, 2023 18:36

jotak force-pushed the metrics-api branch from e7c8a14 to 6e63f3c Compare December 8, 2023 09:52

jotak marked this pull request as ready for review December 8, 2023 09:52

openshift-ci bot removed the do-not-merge/work-in-progress label Dec 8, 2023

jotak added no-qe This PR doesn't necessitate QE approval no-doc This PR doesn't require documentation change on the NetObserv operator labels Dec 8, 2023

openshift-merge-robot added the needs-rebase label Dec 8, 2023

jotak force-pushed the metrics-api branch from 9e92488 to 2424516 Compare December 12, 2023 15:25

openshift-merge-robot removed the needs-rebase label Dec 12, 2023

jotak requested review from msherif1234, OlivierCazade and jpinsonneau December 12, 2023 15:54

jpinsonneau reviewed Dec 13, 2023

View reviewed changes

jotak mentioned this pull request Jan 8, 2024

Custom metrics WIP #445

Closed

10 tasks

OlivierCazade previously approved these changes Jan 9, 2024

View reviewed changes

openshift-ci bot assigned OlivierCazade Jan 9, 2024

openshift-ci bot added the lgtm label Jan 9, 2024

jotak removed the no-qe This PR doesn't necessitate QE approval label Jan 9, 2024

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 9, 2024

jotak added 3 commits January 12, 2024 10:19

dissociate apis in different packages

6e4520d

Add disclaimer about unsupported feature

2eae453

jotak dismissed OlivierCazade’s stale review via 2eae453 January 12, 2024 09:52

jotak force-pushed the metrics-api branch from f27db3e to 2eae453 Compare January 12, 2024 09:52

openshift-ci bot removed the lgtm label Jan 12, 2024

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 12, 2024

jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 12, 2024

openshift-ci bot added the lgtm label Jan 12, 2024

openshift-ci bot added the approved label Jan 12, 2024

openshift-merge-bot bot merged commit ca912f6 into netobserv:main Jan 12, 2024
10 checks passed

NETOBSERV-1342: new FlowMetric API (dev preview) #508

NETOBSERV-1342: new FlowMetric API (dev preview) #508

Conversation

jotak commented Dec 6, 2023 • edited Loading

Description

Dependencies

Checklist

openshift-ci-robot commented Dec 6, 2023 • edited by openshift-ci bot Loading

Description

Dependencies

Checklist

openshift-ci-robot commented Dec 6, 2023 • edited by openshift-ci bot Loading

Description

Dependencies

Checklist

openshift-ci-robot commented Dec 6, 2023 • edited by openshift-ci bot Loading

Description

Dependencies

Checklist

jotak commented Dec 6, 2023

openshift-ci-robot commented Dec 7, 2023 • edited by openshift-ci bot Loading

Description

Dependencies

Checklist

openshift-ci-robot commented Dec 8, 2023 • edited by openshift-ci bot Loading

Description

Dependencies

Checklist

openshift-ci-robot commented Dec 8, 2023 • edited by openshift-ci bot Loading

Description

Dependencies

Checklist

codecov bot commented Dec 8, 2023 • edited Loading

Codecov Report

jpinsonneau Dec 13, 2023

Choose a reason for hiding this comment

jotak Dec 14, 2023

Choose a reason for hiding this comment

jpinsonneau Dec 14, 2023

Choose a reason for hiding this comment

jotak Dec 14, 2023

Choose a reason for hiding this comment

jpinsonneau Dec 13, 2023

Choose a reason for hiding this comment

jotak Jan 8, 2024

Choose a reason for hiding this comment

OlivierCazade left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented Jan 9, 2024 • edited by openshift-ci bot Loading

Description

Dependencies

Checklist

memodi commented Jan 9, 2024

github-actions bot commented Jan 9, 2024

memodi commented Jan 11, 2024 • edited Loading

github-actions bot commented Jan 12, 2024

OlivierCazade commented Jan 12, 2024

jotak commented Jan 12, 2024

openshift-ci bot commented Jan 12, 2024

jotak commented Dec 6, 2023 •

edited

Loading

openshift-ci-robot commented Dec 6, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Dec 6, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Dec 6, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Dec 7, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Dec 8, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Dec 8, 2023 •

edited by openshift-ci bot

Loading

codecov bot commented Dec 8, 2023 •

edited

Loading

openshift-ci-robot commented Jan 9, 2024 •

edited by openshift-ci bot

Loading

memodi commented Jan 11, 2024 •

edited

Loading