Split tests per controller

[jotak]

Description

Following the controllers split, I'm also extracting some of the controller tests to their respective controllers

This is only affecting tests, no "live code" change

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (79eb0be) 66.87% compared to head (21d647d) 67.03%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #510      +/-   ##
==========================================
+ Coverage   66.87%   67.03%   +0.16%     
==========================================
  Files          63       64       +1     
  Lines        7290     7417     +127     
==========================================
+ Hits         4875     4972      +97     
- Misses       2117     2140      +23     
- Partials      298      305       +7     

Flag	Coverage Δ
unittests	67.03% <100.00%> (+0.16%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jotak]

FYI it should be fixing some long standing flaky tests: the root cause I've seen was variables like lastAgentAnnots, lastFLPAnnots .. in certificates integration tests that were incorrectly set (subject to race conditions). I've refactored parts of this certificates integration test

[jotak]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jotak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment