Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image references file #553

Merged
merged 2 commits into from
Feb 5, 2024
Merged

image references file #553

merged 2 commits into from
Feb 5, 2024

Conversation

memodi
Copy link
Contributor

@memodi memodi commented Jan 31, 2024

Description

NETOBSERV-1467 - it appears we need this file to pass operand images to be able to build pre-merge images

See this WIP PR: openshift/release#48224, the e2e-test failed with error when trying to have flowlogs-pipeline as input.

  * could not resolve inputs: could not determine inputs for step [input:flowlogs-pipeline]: could not resolve base image from ocp/latest:flowlogs-pipeline: imagestreamtags.image.openshift.io "latest" not found 

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Copy link

openshift-ci bot commented Jan 31, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jotak for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@memodi
Copy link
Contributor Author

memodi commented Feb 1, 2024

/test e2e-operator

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (12d6378) 57.79% compared to head (3a1e178) 57.87%.
Report is 1 commits behind head on main.

Files Patch % Lines
controllers/flowcollector_controller.go 72.72% 1 Missing and 2 partials ⚠️
controllers/flp/flp_controller.go 70.00% 1 Missing and 2 partials ⚠️
controllers/monitoring/monitoring_controller.go 70.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #553      +/-   ##
==========================================
+ Coverage   57.79%   57.87%   +0.08%     
==========================================
  Files          72       73       +1     
  Lines        9532     9543      +11     
==========================================
+ Hits         5509     5523      +14     
+ Misses       3686     3684       -2     
+ Partials      337      336       -1     
Flag Coverage Δ
unittests 57.87% <75.67%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpinsonneau
Copy link
Contributor

@jotak
Copy link
Member

jotak commented Feb 5, 2024

/lgtm

@memodi memodi merged commit 6d3f3c7 into netobserv:main Feb 5, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants