Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetObserv FLP prow ci config #48224

Merged
merged 1 commit into from
Feb 8, 2024
Merged

NetObserv FLP prow ci config #48224

merged 1 commit into from
Feb 8, 2024

Conversation

memodi
Copy link
Contributor

@memodi memodi commented Jan 30, 2024

NETOBSERV-1467 NetObserv FLP prow ci config

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2024
@openshift-ci openshift-ci bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jan 30, 2024
@memodi
Copy link
Contributor Author

memodi commented Jan 30, 2024

/pj-rehearse pull-ci-netobserv-flowlogs-pipeline-master-unit

@openshift-ci-robot
Copy link
Contributor

@memodi, pj-rehearse: failed to create rehearsal jobs ERROR:

failed to ensure imagestreamtags in cluster build03: failed waiting for imagestreamtag ocp/ubi:9.3 to appear: timed out waiting for the condition

If the problem persists, please contact Test Platform.

@memodi
Copy link
Contributor Author

memodi commented Jan 30, 2024

/pj-rehearse pull-ci-netobserv-flowlogs-pipeline-master-unit

1 similar comment
@memodi
Copy link
Contributor Author

memodi commented Jan 31, 2024

/pj-rehearse pull-ci-netobserv-flowlogs-pipeline-master-unit

@memodi
Copy link
Contributor Author

memodi commented Jan 31, 2024

/pj-rehearse pull-ci-netobserv-flowlogs-pipeline-main-unit

@memodi
Copy link
Contributor Author

memodi commented Jan 31, 2024

/pj-rehearse pull-ci-netobserv-network-observability-operator-main-e2e-operator

@openshift-ci-robot
Copy link
Contributor

@memodi, pj-rehearse: failed to create rehearsal jobs ERROR:

failed to ensure imagestreamtags in cluster build03: failed waiting for imagestreamtag ocp/4.16:flowlogs-pipeline to appear: timed out waiting for the condition

If the problem persists, please contact Test Platform.

@memodi
Copy link
Contributor Author

memodi commented Jan 31, 2024

/pj-rehearse pull-ci-netobserv-network-observability-operator-main-e2e-operator

1 similar comment
@memodi
Copy link
Contributor Author

memodi commented Jan 31, 2024

/pj-rehearse pull-ci-netobserv-network-observability-operator-main-e2e-operator

@openshift-ci-robot
Copy link
Contributor

@memodi, pj-rehearse: failed to create rehearsal jobs ERROR:

failed to ensure imagestreamtags in cluster build03: failed waiting for imagestreamtag ocp/latest:flowlogs-pipeline to appear: timed out waiting for the condition

If the problem persists, please contact Test Platform.

@memodi memodi mentioned this pull request Jan 31, 2024
Merged
10 tasks
@memodi
Copy link
Contributor Author

memodi commented Feb 5, 2024

/pj-rehearse pull-ci-netobserv-network-observability-operator-main-e2e-operator

@openshift-ci-robot
Copy link
Contributor

@memodi, pj-rehearse: failed to create rehearsal jobs ERROR:

failed to ensure imagestreamtags in cluster build03: failed waiting for imagestreamtag ocp/flowlogs-pipeline:main to appear: timed out waiting for the condition

If the problem persists, please contact Test Platform.

@memodi
Copy link
Contributor Author

memodi commented Feb 5, 2024

Sought consultation: https://issues.redhat.com/browse/OCPCRT-300

@openshift-ci-robot
Copy link
Contributor

@memodi, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load ci-operator configuration from release repo: invalid ci-operator config: invalid configuration: promotion.to[0]: both name and tag defined
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@memodi
Copy link
Contributor Author

memodi commented Feb 5, 2024

/pj-rehearse pull-ci-netobserv-flowlogs-pipeline-main-images

@memodi
Copy link
Contributor Author

memodi commented Feb 5, 2024

/pj-rehearse pull-ci-netobserv-network-observability-operator-main-images

@memodi
Copy link
Contributor Author

memodi commented Feb 5, 2024

/pj-rehearse pull-ci-netobserv-network-observability-operator-main-e2e-operator

@openshift-ci-robot
Copy link
Contributor

@memodi, pj-rehearse: failed to create rehearsal jobs ERROR:

failed to ensure imagestreamtags in cluster build01: failed waiting for imagestreamtag netobserv/flowlogs-pipeline:ci to appear: timed out waiting for the condition

If the problem persists, please contact Test Platform.

@openshift-ci-robot
Copy link
Contributor

@memodi, pj-rehearse: failed to create rehearsal jobs ERROR:

failed to ensure imagestreamtags in cluster build03: failed waiting for imagestreamtag netobserv/flowlogs-pipeline:ci to appear: timed out waiting for the condition

If the problem persists, please contact Test Platform.

@memodi
Copy link
Contributor Author

memodi commented Feb 6, 2024

/pj-rehearse pull-ci-netobserv-flowlogs-pipeline-main-unit

@memodi
Copy link
Contributor Author

memodi commented Feb 6, 2024

/pj-rehearse pull-ci-netobserv-network-observability-operator-main-e2e-operator

1 similar comment
@memodi
Copy link
Contributor Author

memodi commented Feb 6, 2024

/pj-rehearse pull-ci-netobserv-network-observability-operator-main-e2e-operator

@memodi
Copy link
Contributor Author

memodi commented Feb 6, 2024

/retest

@memodi memodi changed the title WIP NetObserv FLP prow ci config NetObserv FLP prow ci config Feb 6, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 6, 2024
@memodi
Copy link
Contributor Author

memodi commented Feb 6, 2024

/verify-owners

@openshift-ci openshift-ci bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Feb 6, 2024
@memodi
Copy link
Contributor Author

memodi commented Feb 6, 2024

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 6, 2024
@memodi memodi force-pushed the netobserv-components-config branch from 5b92ca9 to c32e8ef Compare February 6, 2024 18:44
@memodi memodi force-pushed the netobserv-components-config branch from c32e8ef to 97e7c12 Compare February 6, 2024 18:45
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@memodi: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-netobserv-flowlogs-pipeline-main-images netobserv/flowlogs-pipeline presubmit Presubmit changed
pull-ci-netobserv-flowlogs-pipeline-main-unit netobserv/flowlogs-pipeline presubmit Presubmit changed
pull-ci-netobserv-network-observability-operator-main-images netobserv/network-observability-operator presubmit Presubmit changed
pull-ci-netobserv-network-observability-operator-main-ci-index-noo-bundle netobserv/network-observability-operator presubmit Ci-operator config changed
pull-ci-netobserv-network-observability-operator-main-e2e-operator netobserv/network-observability-operator presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 6, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@memodi: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-netobserv-flowlogs-pipeline-main-images netobserv/flowlogs-pipeline presubmit Presubmit changed
pull-ci-netobserv-flowlogs-pipeline-main-unit netobserv/flowlogs-pipeline presubmit Presubmit changed
pull-ci-netobserv-network-observability-operator-main-images netobserv/network-observability-operator presubmit Presubmit changed
pull-ci-netobserv-network-observability-operator-main-ci-index-noo-bundle netobserv/network-observability-operator presubmit Ci-operator config changed
pull-ci-netobserv-network-observability-operator-main-e2e-operator netobserv/network-observability-operator presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 6, 2024

@memodi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/netobserv/flowlogs-pipeline/master/unit c585385 link unknown /pj-rehearse pull-ci-netobserv-flowlogs-pipeline-master-unit
ci/rehearse/netobserv/network-observability-operator/main/images 4b75a9b link unknown /pj-rehearse pull-ci-netobserv-network-observability-operator-main-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@memodi
Copy link
Contributor Author

memodi commented Feb 6, 2024

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 6, 2024
@psalajova
Copy link
Contributor

/approve

@memodi
Copy link
Contributor Author

memodi commented Feb 7, 2024

/cc @jpinsonneau

Could you please help review the configs?

@dhellmann
Copy link
Contributor

Approval for removing the image. I haven't checked the rest of the config changes, so please have your team look at those.

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2024
jpinsonneau
jpinsonneau approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from what I understand. Just use go 1.20 as defined in our go.mod

ci-operator/config/netobserv/flowlogs-pipeline/netobserv-flowlogs-pipeline-main.yaml
image_stream_tag:
name: release
namespace: openshift
tag: golang-1.21
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tag: golang-1.21
tag: golang-1.20

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, jpinsonneau, memodi, psalajova

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 634c0c2 into openshift:master Feb 8, 2024
30 checks passed
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 8, 2024

@memodi: Updated the image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:

  • key mapping_origin_4_16 using file core-services/image-mirroring/openshift/mapping_origin_4_16

In response to this:

NETOBSERV-1467 NetObserv FLP prow ci config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ritmun pushed a commit to ritmun/release that referenced this pull request Feb 8, 2024
@memodi @ritmun
flp prow ci config (openshift#48224)
0500753
@memodi memodi mentioned this pull request Feb 14, 2024
Merged
memodi added a commit to memodi/release that referenced this pull request Mar 14, 2024
@memodi
flp prow ci config (openshift#48224)
5f479cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpinsonneau jpinsonneau jpinsonneau approved these changes

@deepsm007 deepsm007 Awaiting requested review from deepsm007

@eranra eranra Awaiting requested review from eranra

Assignees

@jpinsonneau jpinsonneau

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@memodi @openshift-ci-robot @psalajova @dhellmann @jpinsonneau