NETOBSERV-1664: flowmetric isn't dev preview; also mention samples location #660
Conversation
|
@jotak: This pull request references NETOBSERV-1664 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
(this will have to be backported) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #660 +/- ##
=======================================
Coverage 66.53% 66.53%
=======================================
Files 70 70
Lines 8095 8095
=======================================
Hits 5386 5386
Misses 2315 2315
Partials 394 394
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -1335,8 +1333,7 @@ spec: | |||
| version: 1.0.5 | |||
| webhookdefinitions: | |||
| - admissionReviewVersions: | |||
| - v1beta1 | |||
| - v1beta2 | |||
| - v1 | |||
There was a problem hiding this comment.
why you have this change ?
There was a problem hiding this comment.
not intentional, it was generated. I opened a bug: https://issues.redhat.com/browse/NETOBSERV-1665.
There was a problem hiding this comment.
I restarted the bundle check , this time it passed
Also: I've a fix here: #662
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jotak
added
no-qe
No description provided.