NETOBSERV-1665: use v1 for conversionReviewVersions #662
Conversation
Note we're talking here about versions of ConversionReview (ie. apiextension), NOT versions of our CRDs - Use same versions for flowcollector and flowmetrics - Use just v1 as the only other (v1beta1) was dropped a while ago (kube 1.22 / 2021)
|
@jotak: This pull request references NETOBSERV-1665 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #662 +/- ##
==========================================
- Coverage 66.53% 66.49% -0.04%
==========================================
Files 70 70
Lines 8095 8095
==========================================
- Hits 5386 5383 -3
- Misses 2315 2317 +2
- Partials 394 395 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
jotak
added
no-qe
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 1ac0142
into
netobserv:main
Note we're talking here about versions of ConversionReview (ie. apiextension), NOT versions of our CRDs - Use same versions for flowcollector and flowmetrics - Use just v1 as the only other (v1beta1) was dropped a while ago (kube 1.22 / 2021)
…6] (#670) * Do not load loki cert when loki disabled * NETOBSERV-1665: use v1 for conversionReviewVersions (#662) Note we're talking here about versions of ConversionReview (ie. apiextension), NOT versions of our CRDs - Use same versions for flowcollector and flowmetrics - Use just v1 as the only other (v1beta1) was dropped a while ago (kube 1.22 / 2021)
Note we're talking here about versions of ConversionReview (ie. apiextension), NOT versions of our CRDs