Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resource limits on all applications #81

Closed
denis-tingaikin opened this issue Jan 26, 2021 · 2 comments · Fixed by #727
Closed

Add resource limits on all applications #81

denis-tingaikin opened this issue Jan 26, 2021 · 2 comments · Fixed by #727
Assignees
@Bolodya1997
Labels
bug Something isn't working

Comments

@denis-tingaikin
Copy link
Member

We need to add resource limits for each app in https://github.com/networkservicemesh/deployments-k8s/tree/main/apps
@denis-tingaikin denis-tingaikin added the bug Something isn't working label Jan 26, 2021
@Bolodya1997
Copy link

Right now it is problematic because on such scenario healing starts overusing CPU:

1. Setup NSMgr + Forwarder + Registry
2. Deploy NSE
2. Deploy multiple (~10) NSC
3. Delete NSE without unregistering
4. Delete NSCs

after that NSMgr starts trying to heal all NSC -> NSE connections increasing CPU usage up to 1000m.

Waiting for the networkservicemesh/sdk#738 to fix it.

@Bolodya1997
Copy link

Issue with CPU overusing is still here, but now with refresh:

NAME                            CPU(cores)   MEMORY(bytes)
forwarder-sriov-hm2hc           1m           17Mi
forwarder-sriov-q6scc           5m           26Mi
forwarder-vpp-4x5tl             87m          356Mi
forwarder-vpp-m72gw             81m          340Mi
nsm-registry-6675db8489-qb98c   1m           12Mi
nsmgr-lmb5r                     1m           13Mi
nsmgr-pxfqr                     4163m        43Mi

image

@Bolodya1997 Bolodya1997 mentioned this issue Apr 6, 2021
Merged
nsmbot pushed a commit that referenced this issue Nov 9, 2022
Update go.mod and go.sum to latest version from networkservicemesh/cm…
3351d74 
…d-ipam-vl3@main

PR link: networkservicemesh/cmd-ipam-vl3#81

Commit: 8b6efd5
Author: Denis Tingaikin
Date: 2022-11-09 20:43:50 +0300
Message:
  - Merge pull request #81 from networkservicemesh/update/networkservicemesh/cmd-template
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit that referenced this issue May 29, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
25e46e6 
…d-lb-vl3-vpp@main

PR link: networkservicemesh/cmd-lb-vl3-vpp#81

Commit: cdd7794
Author: Network Service Mesh Bot
Date: 2024-05-29 06:02:59 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#81)
PR link: networkservicemesh/sdk-vpp#833
Commit: 345d2ce
Author: Network Service Mesh Bot
Date: 2024-05-29 05:59:24 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#833)
PR link: networkservicemesh/sdk-kernel#665
Commit: 06cfa69
Author: Network Service Mesh Bot
Date: 2024-05-29 05:55:56 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#665)
PR link: networkservicemesh/sdk#1636
Commit: c01f9e1
Author: Nikita Skrynnik
Date: 2024-05-29 21:53:30 +1100
Message:
                - Add peer cleanup on Requests and Closes from begin (#1636)
* Add peer cleanup on Requests and Closes from begin
* fix go linter issues
* fix race condition + fix all go linter issues
---------
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit that referenced this issue Aug 15, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
aab867f 
…d-csi-driver@main

PR link: networkservicemesh/cmd-csi-driver#81

Commit: 6f970f1
Author: Denis Tingaikin
Date: 2024-08-15 11:33:32 +0300
Message:
  - Merge pull request #81 from Ex4amp1e/add-pprof-enable-conf
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bolodya1997 Bolodya1997

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add applications limits Bolodya1997/deployments-k8s
2 participants
@Bolodya1997 @denis-tingaikin