Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heal rework #738

Merged
merged 28 commits into from
Mar 23, 2021
Merged

Heal rework #738

merged 28 commits into from
Mar 23, 2021

Conversation

artem-belov
Copy link

Fixes #620

Healing scenario:

  1. Make attempt to repeat original Request on the closest previous path element to the broken.
  2. On fail close connection on all path segments after discovery point
  3. Search for the new endpoint and make new Request

Depend on #703

Artem Belov added 4 commits February 26, 2021 12:27
Heal
4723dcb 
Signed-off-by: Artem Belov <artem.belov@xored.com>
Fix linter issues
f82e046 
Signed-off-by: Artem Belov <artem.belov@xored.com>
Skip test depends on restoring connection
2f6b4b9 
Signed-off-by: Artem Belov <artem.belov@xored.com>
Fix goroutine race
8ab29d2 
Signed-off-by: Artem Belov <artem.belov@xored.com>
Remove request updating from monitor
a5d5778 
Signed-off-by: Artem Belov <artem.belov@xored.com>
@denis-tingaikin denis-tingaikin added the blocked Something is blocking this label Mar 2, 2021
Merge remote-tracking branch 'origin/master' into pr-heal-squash
009fa1e 
Signed-off-by: Artem Belov <artem.belov@xored.com>
@denis-tingaikin denis-tingaikin removed the blocked Something is blocking this label Mar 5, 2021
Artem Belov added 5 commits March 9, 2021 14:51
Localbypass Client
063706d 
Signed-off-by: Artem Belov <artem.belov@xored.com>
Restore last valid connection by id
aced21e 
Signed-off-by: Artem Belov <artem.belov@xored.com>
Revert "Localbypass Client"
d37f992 
This reverts commit 063706d.

Signed-off-by: Artem Belov <artem.belov@xored.com>
Fix stuck on unregistered endpoint
ade908c 
Signed-off-by: Artem Belov <artem.belov@xored.com>
Enable NSMgr restored test
a59fd48 
Signed-off-by: Artem Belov <artem.belov@xored.com>
@artem-belov artem-belov force-pushed the pr-heal-squash branch 3 times, most recently from 5f5f3c1 to dc384f2 Compare March 9, 2021 10:39
Merge remote-tracking branch 'origin/master' into pr-heal-squash
5b59e5f 
Signed-off-by: Artem Belov <artem.belov@xored.com>
Fix success request waiting for windows
752c43d 
Signed-off-by: Artem Belov <artem.belov@xored.com>
Fix testing registry clients
c4fa1e2 
Signed-off-by: Artem Belov <artem.belov@xored.com>
@artem-belov artem-belov marked this pull request as ready for review March 9, 2021 15:52
@denis-tingaikin
Copy link
Member

@artem-belov Is this ready to review?

Artem Belov added 2 commits March 17, 2021 17:13
Add restored pods testing
7c18752 
Signed-off-by: Artem Belov <artem.belov@xored.com>
Merge remote-tracking branch 'origin/master' into pr-heal-squash
ea728ad 
Signed-off-by: Artem Belov <artem.belov@xored.com>
@edwarnicke
Copy link
Member

@artem-belov Looks like this needs a rebase?

Merge remote-tracking branch 'origin/master' into pr-heal-squash
a59af4e 
Signed-off-by: Artem Belov <artem.belov@xored.com>
@artem-belov artem-belov force-pushed the pr-heal-squash branch 4 times, most recently from eb2ab14 to 651778b Compare March 18, 2021 05:48
Revert localbypass fix; Skip NSMgr restored heal
920c1d8 
Signed-off-by: Artem Belov <artem.belov@xored.com>
Fix data race
70891b7 
Signed-off-by: Artem Belov <artem.belov@xored.com>
Merge remote-tracking branch 'origin/master' into pr-heal-squash
c724d15 
Signed-off-by: Artem Belov <artem.belov@xored.com>
@edwarnicke
Copy link
Member

@Bolodya1997 @denis-tingaikin Have all your issues been addressed?

Fix refresh after heal request; Add refresh after heal testing
6e1807c 
Signed-off-by: Artem Belov <artem.belov@xored.com>
Close error chan on initial monitor done
30dde03 
Signed-off-by: Artem Belov <artem.belov@xored.com>
@edwarnicke
Copy link
Member

@denis-tingaikin Is this ready to go?

Merge remote-tracking branch 'origin/master' into pr-heal-squash
e588bb9 
Signed-off-by: Artem Belov <artem.belov@xored.com>
denis-tingaikin
denis-tingaikin reviewed Mar 23, 2021
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general most of these changes we've discussed and it looks better than the master heal version.
Added few comments.

pkg/networkservice/common/discover/match_selector.go Outdated Show resolved Hide resolved
pkg/networkservice/common/heal/server.go Outdated Show resolved Hide resolved
pkg/networkservice/common/heal/server.go Show resolved Hide resolved
pkg/networkservice/common/heal/client.go Outdated Show resolved Hide resolved
Pass register heal client func via context
ed6ea14 
Signed-off-by: Artem Belov <artem.belov@xored.com>
@edwarnicke edwarnicke merged commit 9cc8ab5 into networkservicemesh:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwarnicke edwarnicke edwarnicke approved these changes

@Bolodya1997 Bolodya1997 Bolodya1997 approved these changes

@haiodo haiodo Awaiting requested review from haiodo

@glazychev-art glazychev-art Awaiting requested review from glazychev-art

@Tiberivs Tiberivs Awaiting requested review from Tiberivs

@denis-tingaikin denis-tingaikin Awaiting requested review from denis-tingaikin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problematic healing scenarios
4 participants
@artem-belov @denis-tingaikin @edwarnicke @Bolodya1997