Pr fix connect server #703
Conversation
Bolodya1997
force-pushed
the
pr-fix-connect-server
branch
3 times, most recently
from
667e632
to
a6affcc
Compare
Bolodya1997
force-pushed
the
pr-fix-connect-server
branch
2 times, most recently
from
b099c6c
to
9e22e71
Compare
|
@edwarnicke Could you take a look at this patch that's solve issue #704? Any thoughts are welcome :) |
|
@edwarnicke , @Bolodya1997 I think this also can be simplified if we will use a refcountmap that allows deleting entry without looking at ref count. What do you think? |
| @@ -75,11 +75,16 @@ func (u *clientURLClient) init() error { | |||
| u.dialErr = errors.New("cannot dial nil clienturl.ClientURL(ctx)") | |||
| return | |||
| } | |||
|
|
|||
| ctx, cancel := context.WithTimeout(u.ctx, dialTimeout) | |||
There was a problem hiding this comment.
Why are we introducing a new arbitrary dialTimeout instead of deriving it from the ctx of the request?
There was a problem hiding this comment.
It will break discover + roundrobin, because it will wait for the first dial until requests lives and so there won't be any chance to try someone else.
| ) | ||
|
|
||
| type serializeClient struct { | ||
| executor multiExecutor | ||
| executor multiexecutor.MultiExecutor |
There was a problem hiding this comment.
This feels like a separate PR to introduce multiexecutor into serialize. Could we split it out?
|
One way or the other, we need to find a way to not be queueing up all Requests/Closes globally in connect. Its fine to queue them up by Connection.ID... but not globally. I think we can get there with a combination of sync.Map and atomics. |
Signed-off-by: Artem Belov <artem.belov@xored.com>
Signed-off-by: Artem Belov <artem.belov@xored.com>
Signed-off-by: Artem Belov <artem.belov@xored.com>
Signed-off-by: Artem Belov <artem.belov@xored.com>
Signed-off-by: Artem Belov <artem.belov@xored.com>
Signed-off-by: Artem Belov <artem.belov@xored.com>
Signed-off-by: Artem Belov <artem.belov@xored.com>
Signed-off-by: Artem Belov <artem.belov@xored.com>
Signed-off-by: Artem Belov <artem.belov@xored.com>
Signed-off-by: Artem Belov <artem.belov@xored.com>
Signed-off-by: Artem Belov <artem.belov@xored.com>
Signed-off-by: Artem Belov <artem.belov@xored.com>
Signed-off-by: Artem Belov <artem.belov@xored.com>
Signed-off-by: Artem Belov <artem.belov@xored.com>
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Bolodya1997
force-pushed
the
pr-fix-connect-server
branch
from
9e22e71
to
b4b875e
Compare
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Continues #700.
Closes #704.