Skip to content

Commit

Permalink
[qfix] Add return statement in getSpiffeIDFromPath func (#1402)
Browse files Browse the repository at this point in the history
* [qfix] add return statement in getSpiffeIDFromPath

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* use Warnf

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
  • Loading branch information
NikitaSkrynnik committed Dec 19, 2022
1 parent 554e6ac commit 465077a
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkg/registry/common/authorize/common.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ func getRawMap(m *PathIdsMap) map[string][]string {
func getSpiffeIDFromPath(ctx context.Context, path *grpcmetadata.Path) spiffeid.ID {
if len(path.PathSegments) == 0 {
log.FromContext(ctx).Warn("can't get spiffe id from empty path")
return spiffeid.ID{}
}
tokenString := path.PathSegments[0].Token

Expand All @@ -98,7 +99,7 @@ func getSpiffeIDFromPath(ctx context.Context, path *grpcmetadata.Path) spiffeid.

id, err := spiffeid.FromString(subString)
if err != nil {
log.FromContext(ctx).Warn("failed to parse spiffeid from string: %s", err.Error())
log.FromContext(ctx).Warnf("failed to parse spiffeid from string: %s", err.Error())
return spiffeid.ID{}
}
return id
Expand Down

0 comments on commit 465077a

Please sign in to comment.