Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qfix] Add return statement in getSpiffeIDFromPath func #1402

Merged
merged 2 commits into from
Dec 19, 2022

Conversation

NikitaSkrynnik
Copy link
Contributor

@NikitaSkrynnik NikitaSkrynnik commented Dec 19, 2022

Signed-off-by: Nikita Skrynnik nikita.skrynnik@xored.com

Description

Issue link

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
@denis-tingaikin denis-tingaikin merged commit 465077a into networkservicemesh:main Dec 19, 2022
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Dec 19, 2022
…k@main

PR link: networkservicemesh/sdk#1402

Commit: 465077a
Author: Nikita Skrynnik
Date: 2022-12-19 23:52:40 +1100
Message:
  - [qfix] Add return statement in getSpiffeIDFromPath func (#1402)
* [qfix] add return statement in getSpiffeIDFromPath

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* use Warnf

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Dec 19, 2022
…k@main

PR link: networkservicemesh/sdk#1402

Commit: 465077a
Author: Nikita Skrynnik
Date: 2022-12-19 23:52:40 +1100
Message:
  - [qfix] Add return statement in getSpiffeIDFromPath func (#1402)
* [qfix] add return statement in getSpiffeIDFromPath

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* use Warnf

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Dec 19, 2022
…k@main

PR link: networkservicemesh/sdk#1402

Commit: 465077a
Author: Nikita Skrynnik
Date: 2022-12-19 23:52:40 +1100
Message:
  - [qfix] Add return statement in getSpiffeIDFromPath func (#1402)
* [qfix] add return statement in getSpiffeIDFromPath

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* use Warnf

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Dec 19, 2022
…k@main

PR link: networkservicemesh/sdk#1402

Commit: 465077a
Author: Nikita Skrynnik
Date: 2022-12-19 23:52:40 +1100
Message:
  - [qfix] Add return statement in getSpiffeIDFromPath func (#1402)
* [qfix] add return statement in getSpiffeIDFromPath

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* use Warnf

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Dec 19, 2022
…k@main

PR link: networkservicemesh/sdk#1402

Commit: 465077a
Author: Nikita Skrynnik
Date: 2022-12-19 23:52:40 +1100
Message:
  - [qfix] Add return statement in getSpiffeIDFromPath func (#1402)
* [qfix] add return statement in getSpiffeIDFromPath

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* use Warnf

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Dec 19, 2022
…k@main

PR link: networkservicemesh/sdk#1402

Commit: 465077a
Author: Nikita Skrynnik
Date: 2022-12-19 23:52:40 +1100
Message:
  - [qfix] Add return statement in getSpiffeIDFromPath func (#1402)
* [qfix] add return statement in getSpiffeIDFromPath

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* use Warnf

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Dec 19, 2022
…k@main

PR link: networkservicemesh/sdk#1402

Commit: 465077a
Author: Nikita Skrynnik
Date: 2022-12-19 23:52:40 +1100
Message:
  - [qfix] Add return statement in getSpiffeIDFromPath func (#1402)
* [qfix] add return statement in getSpiffeIDFromPath

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* use Warnf

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Dec 19, 2022
…k@main

PR link: networkservicemesh/sdk#1402

Commit: 465077a
Author: Nikita Skrynnik
Date: 2022-12-19 23:52:40 +1100
Message:
  - [qfix] Add return statement in getSpiffeIDFromPath func (#1402)
* [qfix] add return statement in getSpiffeIDFromPath

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* use Warnf

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Dec 19, 2022
…k@main

PR link: networkservicemesh/sdk#1402

Commit: 465077a
Author: Nikita Skrynnik
Date: 2022-12-19 23:52:40 +1100
Message:
  - [qfix] Add return statement in getSpiffeIDFromPath func (#1402)
* [qfix] add return statement in getSpiffeIDFromPath

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* use Warnf

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Dec 19, 2022
…k@main

PR link: networkservicemesh/sdk#1402

Commit: 465077a
Author: Nikita Skrynnik
Date: 2022-12-19 23:52:40 +1100
Message:
  - [qfix] Add return statement in getSpiffeIDFromPath func (#1402)
* [qfix] add return statement in getSpiffeIDFromPath

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* use Warnf

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Dec 19, 2022
…k@main

PR link: networkservicemesh/sdk#1402

Commit: 465077a
Author: Nikita Skrynnik
Date: 2022-12-19 23:52:40 +1100
Message:
  - [qfix] Add return statement in getSpiffeIDFromPath func (#1402)
* [qfix] add return statement in getSpiffeIDFromPath

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* use Warnf

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Dec 19, 2022
…k@main

PR link: networkservicemesh/sdk#1402

Commit: 465077a
Author: Nikita Skrynnik
Date: 2022-12-19 23:52:40 +1100
Message:
  - [qfix] Add return statement in getSpiffeIDFromPath func (#1402)
* [qfix] add return statement in getSpiffeIDFromPath

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* use Warnf

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Dec 19, 2022
…k@main

PR link: networkservicemesh/sdk#1402

Commit: 465077a
Author: Nikita Skrynnik
Date: 2022-12-19 23:52:40 +1100
Message:
  - [qfix] Add return statement in getSpiffeIDFromPath func (#1402)
* [qfix] add return statement in getSpiffeIDFromPath

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* use Warnf

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@NikitaSkrynnik NikitaSkrynnik deleted the qfix branch July 13, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants