Adding cisco_ios_show_ip_interface #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladola
changed the title
CHANGES: * Separate IP address and netmask into separate capture groups (`IPADDR` and `MASK`) * Add catchall error line to ensure we are aware of all data * Add necessary regex matches for known data * Update test parsed file to reflect updates ENHANCEMENTS: * Removed unnecessary `->` from lines that do not have a state change * Move `Record` to the line that begins interface data, removing dependancy on a line that could potentially not exist. * Add capturing VRF for tunnel interfaces, which use a different syntax than other interface types. * Add capture groups for interface status (`LINK_STATUS` and `PROTOCOL_STATUS`)
New Template Updates:
|
@jmcgill298 Looks good. Sorry, I knew about the new requirements, I just had no time in the moment to spend on doing it, so I just posted anyway in case someone needed something similar. Also, unsure why I was not notified of your comment, sorry for the long time to reply. |
jmcgill298
added a commit
that referenced
this pull request
Jan 8, 2019
* Update index/test_index_order.py to match master (resolve conflicts)
* Another attempt to fix conflicts
* Removed duplicate entry for this template
* NEW TEMPLATE UPDATES:
BREAKING CHANGES:
* Change IP Address and Mask to use lists for interfaces with multiple addresses
- `IP_ADDRESS`
- `MASK`
FIXES:
* Correct template order in index file
* Add catch-all to raise an Error on unmatched lines
* Add regex matches for all known lines in test file
* Remove ending `}` from MTU regex to accurately capture MTU size
NEW CAPTURE GROUPS:
* `VRF`: Captures VRF interface is assigned to
GENERAL ENHANCEMENTS:
* Make all spaces uses `\s+`
* Update `IP_ADDRESS` to account for IPv4 and IPv6 Addresses
* Allow for `IP_ADDRESS` to be present without `MASK`
* Simplify regex for `LINK_STATUS`
* Allow for spaces in ACL matches:
- `OUTGOING_ACL`
- `INBOUND_ACL`
TEST FILES:
* Add parsed data for additional `VRF` capture group
* Update parsed file to reflect changes
* Temporarily rename test files'
Added cisco_ios_show_ip_interface to index
* Rebase with master to fix conflicts:
* Rename test files to avoid conflicting names
* Add additional capture groups to template and existing parsed file
jvanderaa
pushed a commit
that referenced
this pull request
Nov 10, 2021
* Adding cisco_ios_show_ip_interface . * Adding cisco_ios_show_ip_interface * fix: from int to intf in cisco_ios_show_ip_interface.parsed * New Template Updates: CHANGES: * Separate IP address and netmask into separate capture groups (`IPADDR` and `MASK`) * Add catchall error line to ensure we are aware of all data * Add necessary regex matches for known data * Update test parsed file to reflect updates ENHANCEMENTS: * Removed unnecessary `->` from lines that do not have a state change * Move `Record` to the line that begins interface data, removing dependancy on a line that could potentially not exist. * Add capturing VRF for tunnel interfaces, which use a different syntax than other interface types. * Add capture groups for interface status (`LINK_STATUS` and `PROTOCOL_STATUS`)
jvanderaa
pushed a commit
that referenced
this pull request
Nov 10, 2021
* Update index/test_index_order.py to match master (resolve conflicts)
* Another attempt to fix conflicts
* Removed duplicate entry for this template
* NEW TEMPLATE UPDATES:
BREAKING CHANGES:
* Change IP Address and Mask to use lists for interfaces with multiple addresses
- `IP_ADDRESS`
- `MASK`
FIXES:
* Correct template order in index file
* Add catch-all to raise an Error on unmatched lines
* Add regex matches for all known lines in test file
* Remove ending `}` from MTU regex to accurately capture MTU size
NEW CAPTURE GROUPS:
* `VRF`: Captures VRF interface is assigned to
GENERAL ENHANCEMENTS:
* Make all spaces uses `\s+`
* Update `IP_ADDRESS` to account for IPv4 and IPv6 Addresses
* Allow for `IP_ADDRESS` to be present without `MASK`
* Simplify regex for `LINK_STATUS`
* Allow for spaces in ACL matches:
- `OUTGOING_ACL`
- `INBOUND_ACL`
TEST FILES:
* Add parsed data for additional `VRF` capture group
* Update parsed file to reflect changes
* Temporarily rename test files'
Added cisco_ios_show_ip_interface to index
* Rebase with master to fix conflicts:
* Rename test files to avoid conflicting names
* Add additional capture groups to template and existing parsed file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT
cisco_ios_show_ip_interface.template, cisco_ios,
show ip interfaceSUMMARY
I needed a way to get Interface name, ip address and VRF (if empty, it's in GRT). Clearly the command has a lot more info than this, and can be expanded in the future if needed.