Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Template Updates: #1

Merged
merged 1 commit into from
Jan 7, 2019
Merged

New Template Updates: #1

merged 1 commit into from
Jan 7, 2019

Conversation

jmcgill298
Copy link

CHANGES:

  • Separate IP address and netmask into separate capture groups (IPADDR and MASK)
  • Add catchall error line to ensure we are aware of all data
  • Add necessary regex matches for known data
  • Update test parsed file to reflect updates

ENHANCEMENTS:

  • Removed unnecessary -> from lines that do not have a state change
  • Move Record to the line that begins interface data, removing dependancy on a line that could potentially not exist.
  • Add capturing VRF for tunnel interfaces, which use a different syntax than other interface types.
  • Add capture groups for interface status (LINK_STATUS and PROTOCOL_STATUS)
ISSUE TYPE
  • New Template Pull Request
  • Bugfix Pull Request
  • Additional Testing
  • Docs Pull Request
COMPONENT
SUMMARY

@jmcgill298
New Template Updates:
abb4a8f 
CHANGES:
  * Separate IP address and netmask into separate capture groups (`IPADDR` and `MASK`)
  * Add catchall error line to ensure we are aware of all data
  * Add necessary regex matches for known data
  * Update test parsed file to reflect updates

ENHANCEMENTS:
  * Removed unnecessary `->` from lines that do not have a state change
  * Move `Record` to the line that begins interface data, removing dependancy on a line that could potentially not exist.
  * Add capturing VRF for tunnel interfaces, which use a different syntax than other interface types.
  * Add capture groups for interface status (`LINK_STATUS` and `PROTOCOL_STATUS`)
@jmcgill298 jmcgill298 mentioned this pull request Jan 2, 2019
Merged
@vladola
Copy link
Owner

vladola commented Jan 7, 2019

Looks good to me. Thanks for this.

@vladola vladola merged commit 6996f2f into vladola:vladola/cisco_ios_show_ip_interface Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcgill298 @vladola