Getter getMissingValues for Phase 2 Store Refactor #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarmoza
added
annotation page
data store
maint:refactor
jarmoza
changed the base branch from
master
to
dev_components_talk_to_store_directly
surchs
requested changes
Feb 9, 2023
There was a problem hiding this comment.
Looks very nice @jarmoza. As mentioned in the comment, I think this is the inverse situation to the previous PR: as far as I understand, this getter is supposed to take a "category" and then go and fetch the missing values from all columns that have been associated with this category.
The annot-missing-values component is (afaik) the only user of this, and it expects a specific format for this - take a look. Make sure to update the getter name in this component as well.
surchs
reviewed
Feb 9, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #278.
This PR implements a getter for retrieving any values that have been marked as "missing' for a particular given column in the annotated data dictionary. The expectation is that if there are any missing values they will be stored in
dataDictionary.annotated.<columnName>.missingValues.Also implemented are unit tests for three scenarios for this getter:
dataDictionary.annotated.<columnName>.missingValuesmissingValueskey) in the column entr in thedataDictionary.annotatedobjectdataDictionary.annotatedThis is related to #275 - which will be implemented following this PR.