-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getter getMissingValues for Phase 2 Store Refactor #355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice @jarmoza. As mentioned in the comment, I think this is the inverse situation to the previous PR: as far as I understand, this getter is supposed to take a "category"
and then go and fetch the missing values from all columns that have been associated with this category.
The annot-missing-values
component is (afaik) the only user of this, and it expects a specific format for this - take a look. Make sure to update the getter name in this component as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @jarmoza, thanks for the changes - didn't realize the PR was still open. Good to go 🎉 !
This closes #278.
This PR implements a getter for retrieving any values that have been marked as "missing' for a particular given column in the annotated data dictionary. The expectation is that if there are any missing values they will be stored in
dataDictionary.annotated.<columnName>.missingValues
.Also implemented are unit tests for three scenarios for this getter:
dataDictionary.annotated.<columnName>.missingValues
missingValues
key) in the column entr in thedataDictionary.annotated
objectdataDictionary.annotated
This is related to #275 - which will be implemented following this PR.