Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing values table items refactor + component test fix #357

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Missing values table items refactor + component test fix #357

merged 2 commits into from
Feb 15, 2023

Conversation

jarmoza
Copy link
Contributor

@jarmoza jarmoza commented Feb 15, 2023 •
edited
Loading

This PR

  1. Simplifies the implementation of the tableItems function in the annot-missing-values component
  2. Fixes the annot-missing-values component test that was broken by Getter getMissingValues for Phase 2 Store Refactor #355 (a name change for the use of the getMissingValues getter in annot-missing-values).
  3. Formats the annot-missing-values component test

@jarmoza jarmoza requested a review from surchs February 15, 2023 17:56
@jarmoza jarmoza added annotation page maint:refactor Simplifying or restructuring existing code or documentation. labels Feb 15, 2023
@jarmoza jarmoza changed the title Missing values table items + component test refactor Missing values table items refactor + component test fix Feb 15, 2023
surchs
surchs approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @jarmoza. Let's collect styling related issues that do not impact functionality so we can address them in one PR. Mixing functional and non-functional changes makes the PR and later the git history harder to understand

@jarmoza
Copy link
Contributor Author

jarmoza commented Feb 15, 2023

@surchs Makes sense to me, re: styling. Will go with that from here on out.

@jarmoza jarmoza merged commit 0ac59ae into dev_components_talk_to_store_directly Feb 15, 2023
@jarmoza jarmoza deleted the missing-values-tableItems-refactor branch February 15, 2023 19:48
@jarmoza jarmoza mentioned this pull request Feb 15, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

Assignees
No one assigned
Labels
annotation page maint:refactor Simplifying or restructuring existing code or documentation.
Projects
Neurobagel
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jarmoza @surchs