No more lists

[alkino]

This is really straight-forward because no one use List anymore when not compiled with Interview.

[azure-pipelines]

✔️ cb09a97 -> Azure artifacts URL

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[azure-pipelines]

✔️ 675e515 -> Azure artifacts URL

[bbpbuildbot]

Logfiles from GitLab pipeline #174330 (:no_entry:) have been uploaded here!

Status and direct links:

• ✅ mac_m1_cmake_build: [cmake, ON, OFF, OFF, address]
• ✅ spack_setup
• ✅ build:nmodl
• ✅ build:neuron:nmodl:intel:legacy
• ✅ build:neuron:nmodl:intel:shared
• ✅ build:neuron:nmodl:nvhpc:acc:legacy
• ✅ build:neuron:nmodl:nvhpc:acc:shared
• ✅ build:neuron:nmodl:nvhpc:omp:legacy
• ✅ build:neuron:nmodl:nvhpc:omp
• ✅ test:neuron:nmodl:intel:legacy
• ⛔ test:neuron:nmodl:intel:shared
• ✅ test:neuron:nmodl:nvhpc:acc:legacy
• ✅ test:neuron:nmodl:nvhpc:acc:shared
• ✅ test:neuron:nmodl:nvhpc:omp:legacy
• ✅ test:neuron:nmodl:nvhpc:omp

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1009732) 66.19% compared to head (675e515) 66.19%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2577   +/-   ##
=======================================
  Coverage   66.19%   66.19%           
=======================================
  Files         559      559           
  Lines      108957   108958    +1     
=======================================
+ Hits        72124    72126    +2     
+ Misses      36833    36832    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[iomaganaris]

Pretty astonished that lists where there but nowhere needed. Good catch 👍

[1uc]

Those didn't vanish by themselves :) He put a lot of effort into removing them prior to this PR.

[iomaganaris]

Those didn't vanish by themselves :) He put a lot of effort into removing them prior to this PR.

Yeah, it rang a bell actually that I saw somewhere a PR about this later 👍

[alkino]

Already done:

• Rewrite resources to use std::vector and update NMODL submodule #2616
• Rewrite observers to use std::vector #2615
• Remove declarePtrList and declareList #2514 (remove 16 usages of List)

[iomaganaris]

Thanks for the references! Great job Nico 👍